Repository navigation
fix: allow NextRow to find ids after FilterApps - #385
Merged
Merged
Conversation
msfrox
added a commit
to msfrox/cosmic-app-library
that referenced
this pull request
Jul 18, 2026
Cherry-picked from upstream PR pop-os#385 (b2bb64b): Id::unique() per rebuild broke NextRow lookups after FilterApps; use deterministic ids instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
We are no longer accepting LLM-generated changes. |
Contributor
Author
|
Err the claude thing above has nothing to do with me. |
Member
|
GitHub really should not display third party commits like that in active pull requests. |
mmstick
force-pushed
the
fix_filter_nextrow
branch
from
September 30, 2026 23:37
b2bb64b to
1410896
Compare
jklgrasso
approved these changes
Oct 8, 2026
wash2
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes down arrow keys just deselecting the edit after searching for something. Now it correctly selects the first item.
This is a one line fix but the problem is pretty complicated.
The short version: iced Tree reuses Id::Unique ids from the old tree when rebuilding the tree(it does so positionally), the new ids generated by update_entry_metadata in Message::FilterApps are basically instantly stale when the tree is rebuilt and the Message:NextRow won't find the ids in entry_ids after the first assignment.