Skip to content

fix: allow NextRow to find ids after FilterApps - #385

Merged
wash2 merged 1 commit into
pop-os:masterfrom
RipleyTom:fix_filter_nextrow
Oct 8, 2026
Merged

wash2 merged 1 commit into
pop-os:masterfrom
RipleyTom:fix_filter_nextrow

Conversation

@RipleyTom

Copy link
Copy Markdown
Contributor

This fixes down arrow keys just deselecting the edit after searching for something. Now it correctly selects the first item.

This is a one line fix but the problem is pretty complicated.
The short version: iced Tree reuses Id::Unique ids from the old tree when rebuilding the tree(it does so positionally), the new ids generated by update_entry_metadata in Message::FilterApps are basically instantly stale when the tree is rebuilt and the Message:NextRow won't find the ids in entry_ids after the first assignment.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

msfrox added a commit to msfrox/cosmic-app-library that referenced this pull request Jul 18, 2026
Cherry-picked from upstream PR pop-os#385 (b2bb64b): Id::unique() per rebuild
broke NextRow lookups after FilterApps; use deterministic ids instead.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jackpot51

Copy link
Copy Markdown
Member

We are no longer accepting LLM-generated changes.

@jackpot51 jackpot51 closed this Sep 30, 2026
@RipleyTom

Copy link
Copy Markdown
Contributor Author

Err the claude thing above has nothing to do with me.
If you don't like the fix I can get it as it's more of a workaround for a bug in iced(though it looked very purposeful when I looked at the code) but don't dismiss it as LLM-generated =.=.

@mmstick mmstick reopened this Sep 30, 2026
@mmstick

mmstick commented Sep 30, 2026

Copy link
Copy Markdown
Member

GitHub really should not display third party commits like that in active pull requests.

@mmstick
mmstick requested review from a team September 30, 2026 23:36
@jklgrasso jklgrasso self-assigned this Oct 8, 2026
@wash2
wash2 merged commit 79b43ef into pop-os:master Oct 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants