Repository navigation
Fix build and add ci - #401
Merged
Merged
Conversation
5 tasks done
hojjatabdollahi
marked this pull request as draft
September 1, 2026 20:19
hojjatabdollahi
force-pushed
the
hojjat/fix-just
branch
from
September 1, 2026 20:24
53c8cbc to
e5babf1
Compare
hojjatabdollahi
marked this pull request as ready for review
September 1, 2026 20:25
LOCKSTEP_XML_PATH to build-vendored only
wash2
approved these changes
Sep 1, 2026
mmstick
reviewed
Sep 1, 2026
jacobgkau
approved these changes
Sep 1, 2026
jacobgkau
left a comment
Member
There was a problem hiding this comment.
It looks like debian/rules uses just build-vendored for dpkg-buildpackage builds, which is why we didn't notice just build-release breaking.
Confirmed this fixes just build-release. Our standard builds with dpkg-buildpackage/just build-vendored are still working. The app library still works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in #399 broke
just build-release.Moving the variable to
build-vendoredfixes the original issue, and doesn't cause regression.Also added a default APP ID so
cargo clippydoesn't fail because of no APP_ID env var.Also not sure why ci.yml was dropped. But I added it back + clippy and test.