Skip to content

Fix build and add ci - #401

Merged
jacobgkau merged 2 commits into
pop-os:masterfrom
hojjatabdollahi:hojjat/fix-just
Sep 1, 2026
Merged

jacobgkau merged 2 commits into
pop-os:masterfrom
hojjatabdollahi:hojjat/fix-just

Conversation

@hojjatabdollahi

@hojjatabdollahi hojjatabdollahi commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

The changes in #399 broke just build-release.

Moving the variable to build-vendored fixes the original issue, and doesn't cause regression.

Also added a default APP ID so cargo clippy doesn't fail because of no APP_ID env var.

Also not sure why ci.yml was dropped. But I added it back + clippy and test.


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@hojjatabdollahi
hojjatabdollahi marked this pull request as ready for review September 1, 2026 20:25
@hojjatabdollahi hojjatabdollahi changed the title fix: move LOCKSTEP_XML_PATH to build-vendored only Fix build and add ci Sep 1, 2026
Comment thread .github/workflows/ci.yml Resolved
@wash2
wash2 requested a review from a team September 1, 2026 20:57
@jacobgkau jacobgkau self-assigned this Sep 1, 2026

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like debian/rules uses just build-vendored for dpkg-buildpackage builds, which is why we didn't notice just build-release breaking.

Confirmed this fixes just build-release. Our standard builds with dpkg-buildpackage/just build-vendored are still working. The app library still works as expected.

@jacobgkau
jacobgkau merged commit 5b7638f into pop-os:master Sep 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants