Repository navigation
fix(network): re-register secret agent after NetworkManager restart - #1480
Merged
Merged
Conversation
wash2
approved these changes
Jul 15, 2026
jklgrasso
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After NetworkManager restarts, nmrs emits
NetworkManagerRestarted; this PR sends a re-registration request to the existing secret-agent task, which callsSecretAgentHandle::reregister(). When NetworkManager returns, it registers the same agent again, so VPN credential prompts work without restarting the panel.An issue has been filed to add opt-in automatic secret-agent re-registration after NetworkManager restarts. freedesktop-rs/nmrs#500
Closes #1477