Skip to content

fix(network): re-register secret agent after NetworkManager restart - #1480

Merged
mmstick merged 1 commit into
pop-os:masterfrom
cachebag:master
Jul 17, 2026
Merged

mmstick merged 1 commit into
pop-os:masterfrom
cachebag:master

Conversation

@cachebag

@cachebag cachebag commented Jul 15, 2026 •

Copy link
Copy Markdown
Contributor
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

After NetworkManager restarts, nmrs emits NetworkManagerRestarted; this PR sends a re-registration request to the existing secret-agent task, which calls SecretAgentHandle::reregister(). When NetworkManager returns, it registers the same agent again, so VPN credential prompts work without restarting the panel.

An issue has been filed to add opt-in automatic secret-agent re-registration after NetworkManager restarts. freedesktop-rs/nmrs#500

Closes #1477

@wash2
wash2 requested a review from a team July 15, 2026 12:52
@mmstick
mmstick merged commit 48c3633 into pop-os:master Jul 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VPN secret agent not re-registered after NetworkManager restarts (e.g. resume from suspend)

4 participants