Skip to content

fix: simplify hover logic - #1503

Merged
wash2 merged 1 commit into
pop-os:masterfrom
RipleyTom:fix_hover
Oct 20, 2026
Merged

wash2 merged 1 commit into
pop-os:masterfrom
RipleyTom:fix_hover

Conversation

@RipleyTom

Copy link
Copy Markdown
Contributor

This fixes that when you had multiple applications, if you closed one the next one would get the focus under the mouse cursor but the overlay(the X to close it) wouldn't show. This simplifies the hovering logic by using the adhoc hover widget.
The X overlay now correctly appears.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@mmstick
mmstick requested a review from a team October 20, 2026 20:43

@jklgrasso jklgrasso left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works as expected. Dock appearance settings, closing one or more open windows on the current or another workspace, moving applets I can still close windows, and context menu(s) all work properly.

@wash2
wash2 merged commit 22a140b into pop-os:master Oct 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants