Repository navigation
fix: a11y: magnifier: change ZoomState::update_focal_point to use f64 to avoid rounding errors - #2516
Merged
Conversation
Contributor
Author
|
Here is my test recording of fix. recording-1782858918_downscaled.mp4 |
leviport
approved these changes
Jul 1, 2026
leviport
left a comment
Member
There was a problem hiding this comment.
This fix is working great, thanks!
Before:
Kooha-2026-06-30-16-32-39.webm
After:
Kooha-2026-06-30-19-10-18.webm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #2515 (erratic cursor movement in magnifier when Zoomed view moves mode is To keep pointer centered --
ZoomMovement::Centered).Please see the issue for full description and screen recording.
By changing the coordinate calculations in
ZoomState::update_focal_pointfromi32tof64, we avoid:Tagging @Drakulix and @leviport , thanks for your help with my last PR!
Screen recording of fix
Attached in comment...