Skip to content

fix: workaround for Chromium apps breaking below 1.0 scaling - #2623

Merged
Drakulix merged 1 commit into
pop-os:masterfrom
RipleyTom:fix_sub_1_fractional
Jul 24, 2026
Merged

Drakulix merged 1 commit into
pop-os:masterfrom
RipleyTom:fix_sub_1_fractional

Conversation

@RipleyTom

Copy link
Copy Markdown
Contributor

This is a fix for chromium apps running under Wayland breaking below 1.0 scaling(ie at 50% and 75%).
Note that I called the commit a fix but it is really a workaround for an issue that is not ours.
Chromium apps under Wayland seem to break when under 100%.
Other applications like Firefox using Wayland seem to work fine under those scales.

I suspect this has something to do with this clamp in Chromium but I couldn't find the exact logic chain that breaks:
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/ui/ozone/platform/wayland/common/wayland_util.cc#329

For scales >= 100% this doesn't change anything.
For scales < 100%, scaling will still works but the surface buffer will be bigger(up to 4x for 50% compared to what it should be) and the surface will be downscaled when rendered(extra GPU work). This is obviously not ideal but I think the tradeoff of running Chromium apps until it gets fixed is worth it.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@Drakulix Drakulix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I wanted to look into this anyway, because I don't think any app was ever really tested for < 1.0 scaling.

So imo we should always clamp to 1 anyway.

@Drakulix
Drakulix requested a review from a team July 24, 2026 11:59
@jacobktm jacobktm self-assigned this Jul 24, 2026

@jacobktm jacobktm left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chromium apps behave correctly after applying this PR.

@Drakulix
Drakulix merged commit 6108cef into pop-os:master Jul 24, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants