Repository navigation
fix: unmap windows from the backup set while no output is connected - #2912
Merged
Merged
Conversation
mayakwd
force-pushed
the
fix/toplevel-ghosts
branch
from
October 7, 2026 13:00
cf5b69a to
88b4ce3
Compare
jklgrasso
previously approved these changes
Oct 7, 2026
mayakwd
force-pushed
the
fix/toplevel-ghosts
branch
2 times, most recently
from
October 8, 2026 09:17
88b4ce3 to
fcf2862
Compare
Contributor
Author
|
Conflicts are resolved, the code stays the same. |
Drakulix
approved these changes
Oct 8, 2026
leviport
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
While no ouput is connected, windows live in the
workspaces.backup_set, butShell:unmap_surfacesearches onlyworkspace.sets. So, a window unmapped in that state will never be removed from the shell and never reachremove_toplevel.It leads to two discrepancies:
The fix
Just unmap surface from
backup_setas well.