Skip to content

fix: unmap windows from the backup set while no output is connected - #2912

Merged
Drakulix merged 1 commit into
pop-os:masterfrom
mayakwd:fix/toplevel-ghosts
Oct 8, 2026
Merged

Drakulix merged 1 commit into
pop-os:masterfrom
mayakwd:fix/toplevel-ghosts

Conversation

@mayakwd

@mayakwd mayakwd commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Issue
While no ouput is connected, windows live in the workspaces.backup_set, but Shell:unmap_surface searches only workspace.sets. So, a window unmapped in that state will never be removed from the shell and never reach remove_toplevel.

It leads to two discrepancies:

  • it stays listed as toplevel - a "ghost" in the dock and launcher (switcher)
  • it's being added again one an output is reconnected

The fix
Just unmap surface from backup_set as well.


  • I have not included any LLM (also known as AI) generated content in this PR, including code, comments, and descriptions.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.
  • I have read and followed all of the above requirements. For more information, see our contributor guide.

@mayakwd
mayakwd force-pushed the fix/toplevel-ghosts branch from cf5b69a to 88b4ce3 Compare October 7, 2026 13:00
Drakulix
Drakulix previously approved these changes Oct 7, 2026

@Drakulix Drakulix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thx!

@Drakulix
Drakulix requested a review from a team October 7, 2026 13:37
@jklgrasso jklgrasso self-assigned this Oct 7, 2026
jklgrasso
jklgrasso previously approved these changes Oct 7, 2026
@mayakwd
mayakwd dismissed stale reviews from jklgrasso and Drakulix via fcf2862 October 8, 2026 09:17
@mayakwd
mayakwd force-pushed the fix/toplevel-ghosts branch 2 times, most recently from 88b4ce3 to fcf2862 Compare October 8, 2026 09:17
@mayakwd

mayakwd commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Conflicts are resolved, the code stays the same.
Unfortunately, as a result approves were dismissed :-)

@mayakwd
mayakwd requested review from Drakulix and jklgrasso October 8, 2026 09:22
@Drakulix
Drakulix requested a review from a team October 8, 2026 09:23
@Drakulix
Drakulix merged commit 8d90d03 into pop-os:master Oct 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants