Skip to content

Save file to recents on save - #585

Merged
wash2 merged 1 commit into
pop-os:masterfrom
nathansgithub:save-to-recents
Jun 30, 2026
Merged

wash2 merged 1 commit into
pop-os:masterfrom
nathansgithub:save-to-recents

Conversation

@nathansgithub

@nathansgithub nathansgithub commented Jun 29, 2026 •

Copy link
Copy Markdown
Contributor

This commit saves file paths to the recents list on save.

Fixes #460


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@jacobgkau
jacobgkau requested review from a team June 29, 2026 22:04
@jacobgkau jacobgkau self-assigned this Jun 29, 2026

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes #460. Thank you for the fix!

Regression testing passed:

Basic operations

  • Type three lines of text (no trailing newline).
  • Copy the last two lines.
  • Paste at the end of the third line (file should now have four lines).
  • Ctrl-Z to undo the paste.
  • Press Enter to add a trailing newline.
  • Paste again (file should now have five lines).
  • Ctrl-Z to undo the paste.
  • Ctrl-Shift-Z to redo the paste.
  • Save the file.
  • Ctrl-F and search for something that has a match.
  • Press Esc twice to exit the Find dialog.
  • Press Ctrl-X to cut the selected search result.
  • Paste the cut text on a new line (file should now have six lines).
  • Re-save the file.
  • Narrow the window until the lines start wrapping (make a line longer if necessary to observe line wrapping).
  • Turn word wrapping off.
  • Scroll right to the end of the document, then left to the beginning again.
    • Active line highlight stops after visible part scrolls; not a regression.
  • Click and drag to select some text past the horizontal edge of the window.
  • Close the file, open COSMIC Edit again, and open the file via the recents list.
  • Close the file again, open COSMIC Edit again, and open the file via the Open dialog.
  • Turn word wrapping back on.

Settings

  • Open View -> Settings.
  • All Appearance settings work.
  • Vim bindings work.

Projects & Git Management

  • Clone the cosmic-edit Git repo and open its directory as a project.
  • Edit -> Find in project... works.
  • Make a change in a file.
  • File -> Git management shows the change and staging it works.
  • Make another change while Git management's open; it updates to show the new change.
  • Un-staging a change works.

Additional Usage

  • Open a large file (e.g. sudo dmesg > dmesg.txt), click and drag to select all of its text, cut, and paste.

@nathansgithub

Copy link
Copy Markdown
Contributor Author

@jacobgkau Thank you for taking a look! Glad to work on this thing that's been bugging me.

@wash2
wash2 merged commit dfcef22 into pop-os:master Jun 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open recent file shows files recently opened, but not files recently saved

3 participants