[sanua356]

The "Open With" context menu item, which allows you to open a file, now includes a search option by application name.

Demo:

cosmic_open_with_search_demo_output.mp4

• I have disclosed use of any AI generated code in my commit messages.
  • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
  • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
• I understand these changes in full and will be able to respond to review comments.
• My change is accurately described in the commit message.
• My contribution is tested and working as described.
• I have read the Developer Certificate of Origin and certify my contribution under its conditions.

[jackpot51]

Do not supply translations beyond the english US ones. The rest are to be filled in by native speakers using weblate.

[sanua356]

@jackpot51 Okay. I will only leave the translation for English and my native language.

UPD: commit completed.

[FAlexei]

Hi! I'm not a designer, but I think it would look cleaner if the "search by app name" text was inside the search field and disappeared when clicked :)

[sanua356]

@FAlexei I was basing it on the fact that the rename and create file windows in cosmic-files are made on the "top header, bottom input field" principle. I don't think it's a good idea to deviate from this concept

[sanua356]

@jackpot51 Good afternoon! Are there any other obstacles to inject PR?

[KodeBarista]

I tried to open a empty text file with zed, there's a checkmark on Zed entry, but the file still opened in COSMIC Edit.

Also,

• Search field should probably autofocus?
• After search, Enter should perform Open
• Clear button & search icon is missing in search-field, which makes it look empty

Hi! I'm not a designer, but I think it would look cleaner if the "search by app name" text was inside the search field and disappeared when clicked :)

A placeholder would be nice, indeed.

COSMIC Monitor impl:

[KodeBarista]

Thank you for taking the feedback and implementing it. It looks and works a lot better now.

The only thing that might be missing is

• Pressing Enter key to open the selection
• Clear button should be in accent color (COSMIC Monitor has got it wrong)

[sanua356]

@KodeBarista Hi! Since the visual interface components are provided by the libcosmic API, I can trigger an event after pressing the “Enter” button only if the input field is in focus, because other elements do not have the on_submit method implemented. The same behavior is observed now in the renaming and file creation forms.

[jacobktm]

This has passed regression testing.

# Testing

This document provides a regression testing checklist for COSMIC Files. The checklist provides a starting point for Quality Assurance reviews.

Checklist

Basic navigation

• Middle-click opens directory in a new tab (not focused).
• Open two scrollable tabs. Scroll one tab, then switch to the other tab; it should not have scrolled.
• Hover over the top item in the folder, then scroll down until it's out of view (while still hovered).
  On scrolling back up (with the mouse in a different position), the item should not have the hover highlight.
• Right-click an item in the sidebar. No visual change should occur with the rest of the items.
• Remove an item from the sidebar, then re-pin it.

File operations

• Right-click -> Create a new folder, then enter it.
• Right-click in the empty folder -> Create a new file.
• Navigate to the parent folder, create another new file, then drag it into the created folder.
• Files can be renamed.
• Files can be opened with non-default apps & browsing store for new apps works.
• Normal right-click shows Move to trash option.
• Shift right-click, and right-click followed by Shift, both show Permanently delete option.

Advanced navigation & view settings

• Image and video thumbnails generate & display in local folders.
• Gallery preview shows with Spacebar.
• Details pane shows with Ctrl+Spacebar.
• Zoom in/out and reset to default zoom work.
• Ctrl+1 and Ctrl+2 switch between list and icon view.
• Ctrl+H shows/hides hidden files.
• Directories can be sorted at top or inline.
• Settings -> Theme works.
• Settings -> Type to Search affects behavior as designed.
• Single-click to open setting takes effect.
• Sorting options work.
• Cutting, copying, and pasting files works.
• F5 reloads current directory.
• Left sidebar can be collapsed and expanded.

External filesystems

• Add a network drive (e.g. SFTP) and navigate into it.
• Plug in a USB drive; able to mount, browse, and eject.

Integrations

• Desktop icons display as expected
• Drag-and-drop into Firefox works

The search field in the 'open with' dialog is nice to have.

[Milli189]

thanks you for adding my feature request! this closes #1893