[jasonrhansen]

Closes #1521

Fixes bug where drag selection only worked if the pointer passed through an item.

The bug was caused by a performance optimization that prevented the selection to update when the selection rectangle was dragged unless certain other events were triggered, such as when hovering over items.

To keep it performant, while fixing the issue, I changed on_drag to take a closure that returns an Option so we can conditionally publish the message. It now checks if the items overlapped by the drag rect changed and only return the message if they have.

• I have disclosed use of any AI generated code in my commit messages.
  • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
  • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
• I understand these changes in full and will be able to respond to review comments.
• My change is accurately described in the commit message.
• My contribution is tested and working as described.
• I have read the Developer Certificate of Origin and certify my contribution under its conditions.

[jacobgkau]

Reproduced #1521, it seems to've been a regression sometime after Epoch 1.6.0. Confirmed this fix works.

Regression testing passed:

Checklist

Basic navigation

• Middle-click opens directory in a new tab (not focused).
• Open two scrollable tabs. Scroll one tab, then switch to the other tab; it should not have scrolled.
• Hover over the top item in the folder, then scroll down until it's out of view (while still hovered). On scrolling back up (with the mouse in a different position), the item should not have the hover highlight.
• Right-click an item in the sidebar. No visual change should occur with the rest of the items.
• Remove an item from the sidebar, then re-pin it.

File operations

• Right-click -> Create a new folder, then enter it.
• Right-click in the empty folder -> Create a new file.
• Navigate to the parent folder, create another new file, then drag it into the created folder.
• Files can be renamed.
• Files can be opened with non-default apps & browsing store for new apps works.
• Normal right-click shows Move to trash option.
• Shift right-click, and right-click followed by Shift, both show Permanently delete option.
  • Currently broken on master: #2062

Advanced navigation & view settings

• Image and video thumbnails generate & display in local folders.
• Gallery preview shows with Spacebar.
• Details pane shows with Ctrl+Spacebar.
• Zoom in/out and reset to default zoom work.
• Ctrl+1 and Ctrl+2 switch between list and icon view.
• Ctrl+H shows/hides hidden files.
• Directories can be sorted at top or inline.
• Settings -> Theme works.
• Settings -> Type to Search affects behavior as designed.
• Single-click to open setting takes effect.
• Recents in sidebar setting works.
• Sorting options work.
• Cutting, copying, and pasting files works.
• F5 reloads current directory.
• Left sidebar can be collapsed and expanded.

External filesystems

• Add a network drive (e.g. SFTP) and navigate into it.
• Plug in a USB drive; able to mount, browse, and eject.

Integrations

• Desktop icons display as expected
• Drag-and-drop into Firefox works