Skip to content

Make Cosmic Files show .exe icons - #2070

Merged
jackpot51 merged 8 commits into
masterfrom
exe-icons
Sep 21, 2026
Merged

jackpot51 merged 8 commits into
masterfrom
exe-icons

Conversation

@jackpot51

@jackpot51 jackpot51 commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Continuation of #1875 , with some additional cleanup

image
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@jackpot51
jackpot51 requested review from a team September 21, 2026 14:40
@jackpot51
jackpot51 marked this pull request as ready for review September 21, 2026 14:54
@jklgrasso jklgrasso self-assigned this Sep 21, 2026

@jklgrasso jklgrasso left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbnails look good. Thumbnails for images, videos, and other types work as expected, including desktop icons.

@jackpot51
jackpot51 merged commit b326e48 into master Sep 21, 2026
8 checks passed
@jackpot51
jackpot51 deleted the exe-icons branch September 21, 2026 19:25
@Milli189

Copy link
Copy Markdown

this should probably be added to cosmic panel as well as other cosmic components, so every component can show the icon of an open .exe app, like apps running in wine and certain windows games that don't have a .desktop file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants