Skip to content

OSK integration - #545

Merged
jackpot51 merged 5 commits into
masterfrom
osk
Sep 22, 2026
Merged

jackpot51 merged 5 commits into
masterfrom
osk

Conversation

@jackpot51

@jackpot51 jackpot51 commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

There will be further design changes in future PRs


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@jackpot51
jackpot51 requested review from a team September 16, 2026 16:47
@jackpot51 jackpot51 self-assigned this Sep 16, 2026
@jackpot51
jackpot51 marked this pull request as ready for review September 17, 2026 20:04

@jacobgkau jacobgkau left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After installing the osk branch on a fresh 24.04 install, the OSK showed up automatically in the greeter on the next boot. For a normal computer/laptop, is it not supposed to wait for me to toggle it?

I was able to dismiss the OSK from the login screen with the X in its corner, but I can't seem to get it back (the On-screen keyboard button doesn't make it reappear).

It defaulted to on because it was an older version of OSK. It defaults to off as expected with a newer version of OSK.

@jacobgkau jacobgkau mentioned this pull request Sep 18, 2026
5 tasks done

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The master version of greeter (0b0d292) focuses the password field automatically on boot. This version (e4a289a) does not, requiring a manual click to focus the password field before I can start typing with a physical keyboard. This does not affect the lock screen, only the login screen.

@jackpot51
jackpot51 requested a review from jacobgkau September 22, 2026 21:54

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The password field is now focused by default as expected again.

Aside from the one-off crash described in pop-os/cosmic-osk#34 (review) (which I can't seem to replicate again right now), the OSK works as expected in the greeter.

@jackpot51
jackpot51 merged commit b87331f into master Sep 22, 2026
5 of 6 checks passed
@jackpot51
jackpot51 deleted the osk branch September 22, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants