Skip to content

fix: cancel session on interactive auth failure - #559

Merged
mmstick merged 1 commit into
pop-os:masterfrom
gngram:pull/pam_session_handling
Oct 7, 2026
Merged

mmstick merged 1 commit into
pop-os:masterfrom
gngram:pull/pam_session_handling

Conversation

@gngram

@gngram gngram commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Complete PAM transactions on failed passwords while preserving non-interactive sessions for retries.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

- Completes PAM transactions on failed passwords while
  preserving non-interactive sessions for retries.

Signed-off-by: Ganga Ram <Ganga.Ram@tii.ae>
@mmstick
mmstick force-pushed the pull/pam_session_handling branch from 3e0cfd5 to 41c6bf4 Compare September 30, 2026 16:41
@jackpot51

Copy link
Copy Markdown
Member

Have you disclosed LLM usage?

@gngram

gngram commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor Author

I didn't use an LLM in this PR. In earlier PR #551 I used LLM to write commit and PR messages to explain the bug. Now in this PR I wrote simple commit messages.

@mmstick
mmstick requested review from a team October 6, 2026 16:56
@jklgrasso jklgrasso self-assigned this Oct 7, 2026
@jklgrasso

jklgrasso commented Oct 7, 2026 •

Copy link
Copy Markdown

The error message for an incorrect password doesn't appear when the user isn't logged in. If the user is logged in, the incorrect password error appears as expected.

Ah, looks like that's not a regression: #483 (comment). I didn't see why this change would affect that, but decided to comment anyway. I should've made sure it wasn't related prior to commenting. My bad.

@mmstick
mmstick merged commit 98df07d into pop-os:master Oct 7, 2026
5 of 6 checks passed
@kajusnau kajusnau mentioned this pull request Nov 4, 2026
11 of 19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants