Repository navigation
audio: Don't show OSD at start, or before both volume and mut are received; and refactor - #232
Conversation
This should not change any behavior.
Only should show OSD on changes.
|
Could the volume OSD always show itself when media hotkeys are used (e.g. if volume up is pressed while volume is already at max), since that's useful to check the current volume level and is the behavior in other desktops? Though I guess that's probably a bigger refactor that's related to #22. |
|
Yeah, that's a good point. But without a way currently to know whether it was a key press that changed the volume, it's probably better to not try that lest it cause spurious notifications from other causes. I don't think the varlink daemon provided by cosmic-settings-daemon indicates that it was a button that caused the toggle, but since cosmic-settings-daemon also handles those keybinds, it probably should be possible to add. |
jklgrasso
left a comment
There was a problem hiding this comment.
Regression testing passed
Checklist
- Volume hotkeys work
- Plugging a headset into a combo jack prompts to select the type
- Screen brightness can be adjusted in 5% increments with hotkeys, down to 1%
- Keyboard backlight brightness can be adjusted via hotkeys
- Airplane mode can be enabled and disabled via hotkey
- Touchpad can be disabled and enabled via hotkey
- Open the Log Out dialog; tab key works to navigate buttons
- Spacebar on Cancel exits dialog
- Not a regression. Enter works
- Esc key (without anything focused) also exits dialog
- Spacebar on Cancel exits dialog
Showing a mic vol indicator at start seems undesirable. This resolves that.
On one system I've been seeing the mic volume indicator appear repeatedly for some reason (maybe related to Bluetooth audio device?). I need to test more to see if that is also fixed, but this should be a good improvement regardless.