Skip to content

audio: Don't show OSD at start, or before both volume and mut are received; and refactor - #232

Merged
wash2 merged 6 commits into
masterfrom
source-sink-volume
Sep 24, 2026
Merged

wash2 merged 6 commits into
masterfrom
source-sink-volume

Conversation

@ids1024

@ids1024 ids1024 commented Sep 22, 2026

Copy link
Copy Markdown
Member

Showing a mic vol indicator at start seems undesirable. This resolves that.

On one system I've been seeing the mic volume indicator appear repeatedly for some reason (maybe related to Bluetooth audio device?). I need to test more to see if that is also fixed, but this should be a good improvement regardless.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@ids1024
ids1024 requested review from a team September 22, 2026 21:26
@git-f0x

git-f0x commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Could the volume OSD always show itself when media hotkeys are used (e.g. if volume up is pressed while volume is already at max), since that's useful to check the current volume level and is the behavior in other desktops? Though I guess that's probably a bigger refactor that's related to #22.

@ids1024

ids1024 commented Sep 22, 2026 •

Copy link
Copy Markdown
Member Author

Yeah, that's a good point. But without a way currently to know whether it was a key press that changed the volume, it's probably better to not try that lest it cause spurious notifications from other causes.

I don't think the varlink daemon provided by cosmic-settings-daemon indicates that it was a button that caused the toggle, but since cosmic-settings-daemon also handles those keybinds, it probably should be possible to add.

@jklgrasso jklgrasso left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression testing passed

Checklist

  • Volume hotkeys work
  • Plugging a headset into a combo jack prompts to select the type
  • Screen brightness can be adjusted in 5% increments with hotkeys, down to 1%
  • Keyboard backlight brightness can be adjusted via hotkeys
  • Airplane mode can be enabled and disabled via hotkey
  • Touchpad can be disabled and enabled via hotkey
  • Open the Log Out dialog; tab key works to navigate buttons
    • Spacebar on Cancel exits dialog
      • Not a regression. Enter works
    • Esc key (without anything focused) also exits dialog

@wash2
wash2 merged commit a0f5fc6 into master Sep 24, 2026
6 checks passed
@wash2
wash2 deleted the source-sink-volume branch September 24, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants