Skip to content

fix: close popups on all outputs before adding a new one - #652

Merged
jacobgkau merged 1 commit into
pop-os:masterfrom
hojjatabdollahi:hojjat/fix-popups
Jul 24, 2026
Merged

fix: close popups on all outputs before adding a new one#652
jacobgkau merged 1 commit into
pop-os:masterfrom
hojjatabdollahi:hojjat/fix-popups

Conversation

@hojjatabdollahi

@hojjatabdollahi hojjatabdollahi commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Fixes #651

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@mmstick
mmstick requested review from a team July 23, 2026 20:23
@jacobgkau jacobgkau self-assigned this Jul 24, 2026
@jacobgkau
jacobgkau force-pushed the hojjat/fix-popups branch from 28a38e3 to 7346afb Compare July 24, 2026 21:30
jacobgkau
jacobgkau approved these changes Jul 24, 2026
View reviewed changes

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes #651.

Not seeing any regressions with appearance or behavior settings, or any of the default applets' functionality.

@jacobgkau
jacobgkau merged commit 5df1bca into pop-os:master Jul 24, 2026
@crocodile crocodile mentioned this pull request Aug 24, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmstick mmstick mmstick approved these changes
@jacobgkau jacobgkau jacobgkau approved these changes

Assignees

@jacobgkau jacobgkau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Panel crashes when opening a tooltip-enabled applet popup across monitors

3 participants

@hojjatabdollahi @mmstick @jacobgkau