Skip to content

fix(cli): escape characters in serial numbers for KDL output - #61

Merged
wash2 merged 1 commit into
masterfrom
escape-serial
Oct 20, 2026
Merged

wash2 merged 1 commit into
masterfrom
escape-serial

Conversation

@mmstick

@mmstick mmstick commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Escapes \ and " characters in serial numbers when outputting in KDL format

Closes pop-os/cosmic-epoch#2111


  • I have not included any LLM (also known as AI) generated content in this PR, including code, comments, and descriptions.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.
  • I have read and followed all of the above requirements. For more information, see our contributor guide.

@mmstick
mmstick requested review from a team October 15, 2026 01:13
@jacobgkau jacobgkau self-assigned this Oct 16, 2026

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a display that was affected by pop-os/cosmic-epoch#2111, and I don't think the team as a whole does, either, based on the comments in that issue and its duplicates. But regression testing on this update looks good with non-affected displays, both single-display and multi-display.

@wash2
wash2 merged commit f1a9765 into master Oct 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display settings blank

3 participants