Repository navigation
Conversation
wash2
approved these changes
Jul 7, 2026
jklgrasso
approved these changes
Jul 8, 2026
jklgrasso
left a comment
Contributor
There was a problem hiding this comment.
Regression testing passed
Checklist
Network & Wireless
Wi-Fi
- Able to disconnect from and connect to a network.
Bluetooth
- Bluetooth device connects.
- Paired device can be disconnected & reconnected.
- Paired device can be forgotten & connecting again works.
Desktop
Wallpaper
- Clicking a different wallpaper switches to it immediately
- Leaving the page and coming back does not change the wallpaper
Appearance
- Open a COSMIC app and a GNOME app. When switching between Dark and Light mode, the COSMIC app switches immediately, and the GNOME app switches after restarting.
- Changing the accent color works.
- Changing the roundness style works and does not affect other aspects of the theme (e.g. color mode).
- Changing the interface density works.
Panel
- Enable tiling. "Automatically hide panel" takes effect immediately.
- Disable tiling; maximize a window. "Automatically hide panel" takes effect immediately.
- Not a regression
Dock
- Enable tiling. "Automatically hide dock" takes effect immediately.
- Disable tiling; maximize a window. "Automatically hide dock" takes effect immediately.
- Not a regression
- Changing position on screen works.
- All Style settings take effect as expected.
Displays
- Plug in a second display. Displays can be rearranged via dragging.
Sound
TBD after devices/profiles are fixed.
Power & Battery
- Changing power mode takes effect and is reflected by top panel applet.
Input Devices
Touchpad
- All click behavior settings work as expected.
- All scrolling settings work as expected.
Applications
Default Applications
- Changing the default terminal affects Super-T shortcut.
X11 Applications Compatibility
- Global Shortcuts in X11 Applications work (in e.g. Discord).
Time & Language
Date & Time
- Changing time zone works.
- Toggling 24-hour time takes effect in Settings preview, on top panel, and on the lock screen.
- Toggling seconds takes effect in Settings preview and on top panel.
- Changing first day of week takes effect in Calendar applet.
- Turning date on/off for applet works.
System & Accounts
About
- Changing hostname works (check terminal prompt).
5 tasks done
This was referenced Jul 21, 2026
leviport
pushed a commit
that referenced
this pull request
Jul 22, 2026
#2097 really should have been caught by QA. It appears only the standard regression testing checklist was performed for #2063, even though that PR only modified the Sound page, and we had nothing in the standard checklist for the Sound page. To rectify that, this adds a few basic smoke tests for the Sound page in the standard checklist, to hopefully prevent this from happening again. (I know we've had this particular problem pop up at least once before, too, so both sliders working independently is a good thing to have in the checklist.) --- - [X] I have disclosed use of any AI generated code in my commit messages. - If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR. - In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment. - [X] I understand these changes in full and will be able to respond to review comments. - [X] My change is accurately described in the commit message. - [X] My contribution is tested and working as described. - [X] I have read the [Developer Certificate of Origin](https://developercertificate.org/) and certify my contribution under its conditions.
krakotay
pushed a commit
to krakotay/cosmic-settings
that referenced
this pull request
Aug 10, 2026
pop-os#2097 really should have been caught by QA. It appears only the standard regression testing checklist was performed for pop-os#2063, even though that PR only modified the Sound page, and we had nothing in the standard checklist for the Sound page. To rectify that, this adds a few basic smoke tests for the Sound page in the standard checklist, to hopefully prevent this from happening again. (I know we've had this particular problem pop up at least once before, too, so both sliders working independently is a good thing to have in the checklist.) --- - [X] I have disclosed use of any AI generated code in my commit messages. - If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR. - In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment. - [X] I understand these changes in full and will be able to respond to review comments. - [X] My change is accurately described in the commit message. - [X] My contribution is tested and working as described. - [X] I have read the [Developer Certificate of Origin](https://developercertificate.org/) and certify my contribution under its conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes pop-os/cosmic-settings-daemon#162
Takes ownership of the settings-daemon varlink client and passes it to a task that waits 128ms before applying and returning the client back to the application. This prevents the client from flooding the varlink server with messages as the slider is dragged. The volume to be applied is updated atomically during that 128ms delay so that the value of the slider at the time of applying is the value that will be sent to the settings daemon.