[ecoezen]

The 'Add image' dialog previously used 'open_file()', which only accepted a single selection. Switching to 'open_files()' lets users select multiple wallpaper images at once.

Changes:

• Rename 'AddFile' to 'AddFiles' to reflect new behavior
• Each selected image is loaded and added as batched via 'Task::batch'
• Introduce 'unwrap_dialog_response' helper.

Closes #2077

• I have disclosed use of any AI generated code in my commit messages.
  • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
  • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
• I understand these changes in full and will be able to respond to review comments.
• My change is accurately described in the commit message.
• My contribution is tested and working as described.
• I have read the Developer Certificate of Origin and certify my contribution under its conditions.

[KodeBarista]

This merge might also address these issues:

• Drag and drop wallpaper adds in the cosmic-settings #1744
• [24.04] Can't add multiple wallpaper images at once #1691

[jklgrasso]

Now able to select multiple files at once. All added images work as expected when set as the wallpaper.

Regression testing passed

Checklist

Network & Wireless

Wi-Fi

• Able to disconnect from and connect to a network.

Bluetooth

• Bluetooth device connects.
• Paired device can be disconnected & reconnected.
• Paired device can be forgotten & connecting again works.

Desktop

Wallpaper

• Clicking a different wallpaper switches to it immediately
• Leaving the page and coming back does not change the wallpaper

Appearance

• Open a COSMIC app and a GNOME app. When switching between Dark and Light mode, the COSMIC app switches immediately, and the GNOME app switches after restarting.
• Changing the accent color works.
• Changing the roundness style works and does not affect other aspects of the theme (e.g. color mode).
• Changing the interface density works.

Panel

• Enable tiling. "Automatically hide panel" takes effect immediately.
• Disable tiling; maximize a window. "Automatically hide panel" takes effect immediately.
  • Not a regression

Dock

• Enable tiling. "Automatically hide dock" takes effect immediately.
• Disable tiling; maximize a window. "Automatically hide dock" takes effect immediately.
  • Not a regression
• Changing position on screen works.
• All Style settings take effect as expected.

Displays

• Plug in a second display. Displays can be rearranged via dragging.

Sound

TBD after devices/profiles are fixed.

Power & Battery

• Changing power mode takes effect and is reflected by top panel applet.

Input Devices

Touchpad

• All click behavior settings work as expected.
• All scrolling settings work as expected.

Applications

Default Applications

• Changing the default terminal affects Super-T shortcut.

X11 Applications Compatibility

• Global Shortcuts in X11 Applications work (in e.g. Discord).

Time & Language

Date & Time

• Changing time zone works.
• Toggling 24-hour time takes effect in Settings preview, on top panel, and on the lock screen.
• Toggling seconds takes effect in Settings preview and on top panel.
• Changing first day of week takes effect in Calendar applet.
• Turning date on/off for applet works.

System & Accounts

About

• Changing hostname works (check terminal prompt).

[ecoezen]

just rebased. let me know if anything more required from my end @jklgrasso @mmstick

[ecoezen]

This merge might also address these issues:

* [Drag and drop wallpaper adds in the cosmic-settings #1744](https://github.com/pop-os/cosmic-settings/issues/1744)

* [[24.04] Can't add multiple wallpaper images at once #1691](https://github.com/pop-os/cosmic-settings/issues/1691)

indeed, these 2 issues can/should be closed. #1744 is requesting "drag-n-drop or 'alternatively' multiple image selection", seems to be addressed already. fyi.