Skip to content

touchpad: controls for tap-and-drag options - #2236

Merged
mmstick merged 1 commit into
pop-os:masterfrom
thatdevsherry:feat/touchpad-drag-options
Oct 13, 2026
Merged

mmstick merged 1 commit into
pop-os:masterfrom
thatdevsherry:feat/touchpad-drag-options

Conversation

@thatdevsherry

@thatdevsherry thatdevsherry commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1844

When tap-to-click is enabled, show 2 new toggles: tap-and-drag and drag-lock.

This is mandatory for me because firefox acts weird when both tap-and-drag and two-finger-tap-to-right-click is enabled.

Weirdness being:

  1. Double tap and let fingers off
  2. Without delay, tap single finger after the above
  3. Move cursor with tapped finger to e.g. "Select All" in the right-click menu
  4. Release finger on a selection, it gets auto-clicked. This doesn't happen when tap-and-drag is off, so it would seem firefox treats this as tap-and-drag flow, which it is not.

Note: I added the translation for en only. rust-analyzer shows an error but cargo builds fine. Not sure if I have wired the translation correctly. It shows the text correctly though.

image image
  • I have not included any LLM (also known as AI) generated content in this PR, including code, comments, and descriptions.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.
  • I have read and followed all of the above requirements. For more information, see our contributor guide.

when tap-to-click is enabled, show 2 new toggles to modify tap-and-drag
and drag-lock
@mmstick
mmstick requested review from a team October 9, 2026 12:19
@jklgrasso jklgrasso self-assigned this Oct 12, 2026

@jklgrasso jklgrasso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The controls work as I expect.

Regression testing passed

Checklist

Network & Wireless

Wi-Fi

  • Able to disconnect from and connect to a network.

Bluetooth

  • Bluetooth device connects.
  • Paired device can be disconnected & reconnected.
  • Paired device can be forgotten & connecting again works.

Desktop

Wallpaper

  • Clicking a different wallpaper switches to it immediately
  • Leaving the page and coming back does not change the wallpaper

Appearance

  • Open a COSMIC app and a GNOME app. When switching between Dark and Light mode, the COSMIC app switches immediately, and the GNOME app switches after restarting.
  • Changing the accent color works.
  • Changing the roundness style works and does not affect other aspects of the theme (e.g. color mode).
  • Changing the interface density works.

Panel

  • Enable tiling. "Automatically hide panel" takes effect immediately.
  • Disable tiling; maximize a window. "Automatically hide panel" takes effect immediately.

Dock

  • Enable tiling. "Automatically hide dock" takes effect immediately.
  • Disable tiling; maximize a window. "Automatically hide dock" takes effect immediately.
  • Changing position on screen works.
  • All Style settings take effect as expected.

Displays

  • Plug in a second display. Displays can be rearranged via dragging.
  • Display mirroring works.

Sound

  • Output & Input volume sliders work independently
  • Output balance slider works & doesn't get reset by volume slider
  • Amplification toggles work as expected
  • Device profiles can be changed & reflect as expected on the main Sound page
  • Applications using sound appear on the Applications sub-page
  • Application volume and mute controls only affect the selected playback stream
  • Closing an playback stream removes it from the Applications sub-page

Power & Battery

  • Changing power mode takes effect and is reflected by top panel applet.

Input Devices

Touchpad

  • All click behavior settings work as expected.
  • All scrolling settings work as expected.

Applications

Default Applications

  • Changing the default terminal affects Super-T shortcut.

X11 Applications Compatibility

  • Global Shortcuts in X11 Applications work (in e.g. Discord).

Time & Language

Date & Time

  • Changing time zone works.
  • Toggling 24-hour time takes effect in Settings preview, on top panel, and on the lock screen.
  • Toggling seconds takes effect in Settings preview and on top panel.
  • Changing first day of week takes effect in Calendar applet.
  • Turning date on/off for applet works.

System & Accounts

About

  • Changing hostname works (check terminal prompt).

@mmstick
mmstick merged commit f3b1b60 into pop-os:master Oct 13, 2026
4 checks passed
@thatdevsherry
thatdevsherry deleted the feat/touchpad-drag-options branch October 14, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose libinput tag and drag lock

3 participants