Repository navigation
touchpad: controls for tap-and-drag options - #2236
Merged
Merged
Conversation
when tap-to-click is enabled, show 2 new toggles to modify tap-and-drag and drag-lock
jklgrasso
approved these changes
Oct 13, 2026
jklgrasso
left a comment
Contributor
There was a problem hiding this comment.
Looks good. The controls work as I expect.
Regression testing passed
Checklist
Network & Wireless
Wi-Fi
- Able to disconnect from and connect to a network.
Bluetooth
- Bluetooth device connects.
- Paired device can be disconnected & reconnected.
- Paired device can be forgotten & connecting again works.
Desktop
Wallpaper
- Clicking a different wallpaper switches to it immediately
- Leaving the page and coming back does not change the wallpaper
Appearance
- Open a COSMIC app and a GNOME app. When switching between Dark and Light mode, the COSMIC app switches immediately, and the GNOME app switches after restarting.
- Changing the accent color works.
- Changing the roundness style works and does not affect other aspects of the theme (e.g. color mode).
- Changing the interface density works.
Panel
- Enable tiling. "Automatically hide panel" takes effect immediately.
- Disable tiling; maximize a window. "Automatically hide panel" takes effect immediately.
Dock
- Enable tiling. "Automatically hide dock" takes effect immediately.
- Disable tiling; maximize a window. "Automatically hide dock" takes effect immediately.
- Changing position on screen works.
- All Style settings take effect as expected.
Displays
- Plug in a second display. Displays can be rearranged via dragging.
- Display mirroring works.
Sound
- Output & Input volume sliders work independently
- Output balance slider works & doesn't get reset by volume slider
- Amplification toggles work as expected
- Device profiles can be changed & reflect as expected on the main Sound page
- Applications using sound appear on the Applications sub-page
- Application volume and mute controls only affect the selected playback stream
- Closing an playback stream removes it from the Applications sub-page
Power & Battery
- Changing power mode takes effect and is reflected by top panel applet.
Input Devices
Touchpad
- All click behavior settings work as expected.
- All scrolling settings work as expected.
Applications
Default Applications
- Changing the default terminal affects Super-T shortcut.
X11 Applications Compatibility
- Global Shortcuts in X11 Applications work (in e.g. Discord).
Time & Language
Date & Time
- Changing time zone works.
- Toggling 24-hour time takes effect in Settings preview, on top panel, and on the lock screen.
- Toggling seconds takes effect in Settings preview and on top panel.
- Changing first day of week takes effect in Calendar applet.
- Turning date on/off for applet works.
System & Accounts
About
- Changing hostname works (check terminal prompt).
mmstick
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1844
When tap-to-click is enabled, show 2 new toggles:
tap-and-draganddrag-lock.This is mandatory for me because firefox acts weird when both
tap-and-dragandtwo-finger-tap-to-right-clickis enabled.Weirdness being:
tap-and-dragis off, so it would seem firefox treats this astap-and-dragflow, which it is not.Note: I added the translation for
enonly. rust-analyzer shows an error but cargo builds fine. Not sure if I have wired the translation correctly. It shows the text correctly though.