Repository navigation
Upstream compliant theming - #322
Conversation
This is the result of making sure Pop does not break upstream GNOME apps. It's very Pop-y, but with metrics and features that give it 100% feature parity with Adwaita which helps ensure upstream apps will not break if a user is using this theme. It's current incomplete, so it should be considered alpha-quailty for now.
|
Please be aware that checkboxes in Repoman are too-close together with this theme. This is fixed in pop-os/repoman#20 |
These have been outdated for a long time anyway, and don't represent an accurate image of the theme. Lots of images of the theme are available in screenshots online, and these represent an undue maintenance burden. Also point the logo towards master
|
Documentation updates should also include replacing the build instructions involving |
|
Will there be slim variations for these themes? |
|
On 19.10 where I have installed the appropriate .debs as provided I am seeing odd overlay/padding on the system menu as well as the "notification menu"(not sure of proper name for it). I see this in both the normal theme and dark theme.
This is the configuration I have in gnome-tweaks:
|
|
Not sure if it is intentional, but the column selections ("Name", "Size", "Modified", etc) in nautilus are the exact same color as the background. This may make it unclear that the headers are selectable.
This also appears to be the case in the dark theme as well. |
|
Quick notes - stuff to cover with Kate:
|
|
@brs17 That is a side effect the the @WatchMkr WRT:
This is actually a lot more consistent with GTK, where popovers also use the arrow. I think a large part of what makes them not so great is the aforementioned bug with the -testing theme installation. On the actual installed version, the effect works a lot better and it helps provide a visual hierarchy for where the popup is coming from. I think we should wait until it's easier to test with the way that will actually look before we make a final decision on that. One important note is that the visual glitch is caused by a bug in the current Pop shell theme directly related to removing those arrows. When the system theme doesn't use the arrows, and you select a shell theme that does, it creates that issue. Keeping the arrows prevents this sort of glitch and ensures that the Pop theme doesn't break other themes. |
@brs17 That might be possible, although the Slim themes will cause breakage with apps because of padding changes. |
👍 If that is the case, we will want to remove the |
|
Take a closer look at the orange used in the light theme with Kate. Dark theme colors come across as smooth and fitting. Taffy instead of hard candy. Light theme colors (especially orange) look saturated. Hard candy instead of taffy. |
|
@WatchMkr updated Debs with the latest fixes: |
|
dpkg errors still cause failure to add the new theme via the upstream-compliant staging repository. Errors when trying to add the theme: |
|
Installing it still seemed to work just fine with an |
|
The |
|
In GNOME Calendar, when creating a new event, the label which shows which calendar the event will be added to, might be too low contrast. Notice where it says "Personal" in the top bar. 19.10: 19.04: |
This does look better. I do notice that the text color of the headers looks very light, almost as if they are deactivated/not clickable. Might a slightly darker font be better here? |
|
Per offline discussion, let's make sure that updates on a system work well...let's potentially solve this issue #322 (comment) and then I'll give the 👍 and we can merge it to master_eoan. From there, individual issues will be created for issues found. This already looks really good and I think a lot of people will love it! |
|
#322 (comment) has been addressed, and everything appears to work. The theme is correctly updated and applied on both upgrades and new installations. |
|
@brs17 I already created issues for the other outstanding notes. |
|
I still got a warning, but after a reboot, the theme seems to be working just fine.
|
|
@brs17 What do you get for output of |
* Big change. This makes Pop more upstream-compliant This is the result of making sure Pop does not break upstream GNOME apps. It's very Pop-y, but with metrics and features that give it 100% feature parity with Adwaita which helps ensure upstream apps will not break if a user is using this theme. It's current incomplete, so it should be considered alpha-quailty for now. * Install dark theme too * Render assets, style scales * Add elementary widgets styling * Fix Search results width * Ignore build obj folder * Calendar fixes * Menu fixes * Use dark theme for GDM * Fix broken GResource * Remove screenshots from README These have been outdated for a long time anyway, and don't represent an accurate image of the theme. Lots of images of the theme are available in screenshots online, and these represent an undue maintenance burden. Also point the logo towards master * Fix broken GResource for light theme too. * Shell: Calendar day fixes * Shell: Contrast improvement on close button * Fix large user icon in system menu * Fix lintian error with changelog * Documentation updates * Move slider styling out of _common and into Tweaks for easier maintenance * Improve dark theme selected item backdrop foreground color * Fix borders on Nautilus list-view headers * Correct typo with color pallete * Fix old color functions and replace with rgba * Fix path issue with assets * Attempt to fix upgrade errors with debian packaging. * Fix theme installation error. * Make sure we're hitting the correct GNOME Shell theme version * Remove Extra files.
It is expected that 19.10 will ship with the new Adwaita-based Pop theme to increase compatibility with GNOME applications and reduce bugs and breakages. This new codebase represents this work to produce a "compatible" theme which still presents a distinctive Pop identity to the OS.
Architectural changes:
pop-default-settingsVisual Updates
Current TODOs with this Theme:
disco-compatible testing branch to allow employees to dogfood the new theme and provide feedback about visuals and design._common.scssto_tweaks.scss. This should not affect the appearance of the theme.