Skip to content

fix(text_input): remove capture_escape property - #1474

Merged
mmstick merged 1 commit into
masterfrom
capture-escape
Oct 13, 2026
Merged

mmstick merged 1 commit into
masterfrom
capture-escape

Conversation

@mmstick

@mmstick mmstick commented Oct 13, 2026

Copy link
Copy Markdown
Member

Removes the capture_escape method added in #1460

The default behavior should be to not capture the escape key event


  • I have not included any LLM (also known as AI) generated content in this PR, including code, comments, and descriptions.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.
  • I have read and followed all of the above requirements. For more information, see our contributor guide.

The default behavior should be to not capture the escape key event
@mmstick
mmstick requested a review from a team October 13, 2026 21:58
@mmstick
mmstick merged commit e1f2cd2 into master Oct 13, 2026
16 checks passed
@mmstick
mmstick deleted the capture-escape branch October 13, 2026 22:15
@jackpot51

Copy link
Copy Markdown
Member

@mmstick Do you have a way to prevent regressions pop-os/cosmic-settings#2238 (comment)

@mmstick

mmstick commented Oct 13, 2026 •

Copy link
Copy Markdown
Member Author

This removes the behavior to capture the escape key event so it fixes the previous issues without needing to insert .capture_escape(false) everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants