Repository navigation
fix(text_input): remove capture_escape property - #1474
Merged
Merged
Conversation
The default behavior should be to not capture the escape key event
jackpot51
approved these changes
Oct 13, 2026
Member
|
@mmstick Do you have a way to prevent regressions pop-os/cosmic-settings#2238 (comment) |
Member
Author
|
This removes the behavior to capture the escape key event so it fixes the previous issues without needing to insert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
capture_escapemethod added in #1460The default behavior should be to not capture the escape key event