Repository navigation
fix: eliminate all baselined Pyrefly errors - #2368
Merged
Merged
Conversation
karangattu
changed the title
karangattu
changed the title
… shared dict `wrap_all_in_gap_spaced_container()` hoisted a single `TagAttrs` dict out of the loop and passed it to every child's `div()`. That is only safe because htmltools copies attrs into a fresh `TagAttrDict` per tag; nothing in this file stated that dependency. Passing `class_=` instead gives each wrapper its own attributes and drops the `TagAttrs` annotation the dict needed. Rendered HTML is unchanged (verified byte-identical across layout_column_wrap and layout_columns with fillable on/off, col_widths, and a user `class_`). Adds unit coverage for the wrapper class values.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves all 235 errors previously recorded in
pyrefly-baseline.json, leaving the baseline empty.The changes:
Multiprocessconstructor without conflicting type-ignore comments