Repository navigation
Make pygame.typing.PathLike internal/private - #3086
Merged
Merged
Conversation
damusss
requested changes
Aug 30, 2024
damusss
left a comment
damusss
left a comment
Member
There was a problem hiding this comment.
This isn't particularly important, the rest looks good!
MyreMylar
approved these changes
Aug 30, 2024
MyreMylar
left a comment
MyreMylar
left a comment
Member
There was a problem hiding this comment.
This seems reasonable I agree that the the os.PathLike vs pygame.typing.PathLike is likely to be confusing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3085
Renames all occurrences from
PathLiketo_PathLike, and removes it from docs and__all__list.