Repository navigation
Draw arc test in draw_test.py - #3230
Merged
Merged
Conversation
ankith26
approved these changes
Nov 27, 2024
ankith26
left a comment
ankith26
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for contributing to pygame-ce 🥳
Thanks to the PR of the original author as well!
Member
|
Requesting Myre's review as they had reviewed the original PR |
1 task
bilhox
approved these changes
Nov 29, 2024
bilhox
left a comment
bilhox
left a comment
Contributor
There was a problem hiding this comment.
LGTM ! Thanks for the contribution 😄 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the test test_arc__correct_drawing() in draw_test.py as asked in #2636 and #2638 .
I added a wider range of widths and angles to test the arc function.