[ankith26]

I was looking at compiling Window under SDL3, and seems like SDL_WINDOW_FOREIGN is now gone, with no mention or a replacement in SDL3. The easiest thing to do now seems to be undocumenting, and the code now raises a deprecation warning if the foreign kwarg is received.

[ankith26]

Also added another deprecation for the input_only kwarg which does not have an SDL3 equivalent.

Now the only think left to address in porting Window in my view, is fullscreen_desktop. I think SDL3 didn't technically remove it, but they seem to have changed it a lot and I may be stuck on how to handle this one

[damusss]

Makes sense, LGTM 👍

[yunline]

Accroding to this commit the SDL_WINDOW_FOREIGN is not removed. It's renamed to SDL_WINDOW_EXTERNAL.

However I approve to deprecate this kwarg.

In Window.__init__ we create a SDL window, However SDL_WINDOW_EXTERNAL is a flag for "window not created by SDL". Setting this kwarg doesn't make any sence.

[yunline]

LGTM

[MyreMylar]

LGTM I guess, external would be a clearer keyword anyway if we need it for some reason (integration with Tkinter maybe?)