Repository navigation
Port over more SDL functions to SDL3 - #3451
Merged
Merged
Conversation
damusss
approved these changes
May 31, 2025
damusss
left a comment
damusss
left a comment
Member
There was a problem hiding this comment.
I like the inline strategy to avoid having conditional preprocessives all over the place convoluting the code. LGTM!
Starbuck5
force-pushed
the
sdl3-moar-functions
branch
from
May 31, 2025 10:22
0e23dc7 to
1ff8759
Compare
JoKing-1999
approved these changes
May 31, 2025
JoKing-1999
left a comment
JoKing-1999
left a comment
Member
There was a problem hiding this comment.
LGTM, you defined all the modified functions, and change conditions the right way with the SDL3 (from == 0 to != 0, and other alternatives)
👍
Member
Author
|
(Just force pushed to rebase)
And they're all in the SDL3 style, so in the future when we only support SDL3 we can just switch PG_ to SDL_. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles SDL_LockSurface and SDL_FillRect.
This is a prerequisite to #3435, since that one is giving me warnings (that I don't get locally) related to these functions.
This is similar to #3434