Repository navigation
Re exclude korean tutorials in release wheels and run important CI everytime - #3478
Conversation
|
#3353 |
|
There are a lot of files and we would have to trial and error manually. The first suspect is all korean files. I don't have a mac so someone else would need to do this. |
|
It has to be someone with a developer license from apple I think, I tried with my mac, but it worked for me (but the sign was only valid on my own mac) |
|
I think for now we have a good compromise - only the korean tuts are excluded. Anyone who wants the english/spanish tuts can still access it from the wheel. The korean tuts should continue to be available on pyga.me so I think excluding it in the wheels doesn't really cause problems to anyone. @davidfokkema has confirmed that the current state of this PR fixes the issue (thanks again for all the testing!) |
ankith26
changed the title
oddbookworm
left a comment
oddbookworm
left a comment
There was a problem hiding this comment.
LGTM! We'll have to keep in mind to exclude any non-ASCII docs names in the future
PR to hopefully fix #3468