Skip to content

Port more SDL functions (SDL3) - #3515

Merged
damusss merged 3 commits into
pygame-community:mainfrom
Starbuck5:port-more-sdl-functions
Jul 12, 2025
Merged

damusss merged 3 commits into
pygame-community:mainfrom
Starbuck5:port-more-sdl-functions

Conversation

@Starbuck5

Copy link
Copy Markdown
Member

While #3435 does get Surface compiling, it's actual functionality is quite limited due to the prevalence of SDL int return code -> bool return code issues.

When combined with #3435 and built on SDL3, this brings the surface test suite from
FAILED (failures=8, errors=198, skipped=2) to FAILED (failures=5, errors=130, skipped=2), a significant improvement. A lot of the remaining fails after this are about the lack of display.

@Starbuck5
Starbuck5 requested a review from a team as a code owner June 21, 2025 22:23
@Starbuck5 Starbuck5 added sdl3 Surface pygame.Surface labels Jun 21, 2025
@ankith26 ankith26 added this to the 2.5.6 milestone Jun 22, 2025

@ankith26 ankith26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damusss damusss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@damusss
damusss merged commit a6db5c7 into pygame-community:main Jul 12, 2025
@Starbuck5
Starbuck5 deleted the port-more-sdl-functions branch July 14, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdl3 Surface pygame.Surface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants