Repository navigation
Conversation
ankith26
left a comment
There was a problem hiding this comment.
numpy pypy 3.11 manylinux wheels are manylinux_2_28, so the wheels cannot be installed on our manylinux_2_17 (AKA manylinux2014) build environment. The easiest fix here is to simply skip numpy on pypy 3.11 manylinux.
Is updating our build an option? |
Co-authored-by: Ankith <itsankith26@gmail.com>
That can be considered in the long term but for now I think that would be the worse option. We would loose support for some older platforms if we did that, and for little benefit (testing numpy specific features on pypy 3.11) |
"older platforms" |
We would lose support! @ankith26 It is now my mission in life to make sure you use the right lose/loose, I'm sorry to impose. |
So I did some research. We're using manylinux2014, which is still supported by the pypa. The next step up is manylinux_2_28. (manylinux2014 is basically manylinux_2_17). Making that jump drops Debian (8, 9) and Ubuntu (14.04, 16.04, 18.04). Ubuntu 20.04 came out on April 23rd 2020, so if someone set up their computer on April 22nd 2020 with Ubuntu they would have 18.04 (I think). Being able to install new software on a computer set up a little bit over 5 years ago sounds reasonable to me. That being said that version of Ubuntu is officially out of support now. See this table for support dates vs manylinux versions: https://github.com/mayeut/pep600_compliance?tab=readme-ov-file#distro-compatibility |
Sure, but that's assuming they haven't updated their distro at all to a newer release version and are actively rocking an EOL version of ubuntu. |
|
I think we can merge this PR as it is and worry about manylinux bumping in a future PR (which will anyways involve a bit more work) |
* Add pypy 3.11 support * Upgrade cython version * Allow for numpy prerelease for pypy 3.11 * Numpy DOES have a full pypy 3.11 release... * drop pypy 3.9 Co-authored-by: Ankith <itsankith26@gmail.com> * Skip numpy on manylinux x86_64 pypy 3.11 --------- Co-authored-by: Ankith <itsankith26@gmail.com>
No description provided.