Repository navigation
Harden gh actions workflows - #3759
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (7)
📝 WalkthroughWalkthroughWorkflows and Dependabot config updated: Dependabot gains a 7-day cooldown; many GitHub Actions workflows add explicit Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/build-debian-multiarch.yml:
- Around line 38-40: The workflow's permissions block only grants contents: read
but the uraimo/run-on-arch-action steps use githubToken to cache GHCR images;
update the permissions block (the top-level permissions: mapping) to include
packages: write and packages: read so the action can push and pull container
cache layers when the install step runs; locate the permissions block in the
workflow and add the two packages entries alongside contents: read.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0d06e897-f44b-485b-9c89-a5abe40cd455
📒 Files selected for processing (12)
.github/dependabot.yml.github/workflows/build-debian-multiarch.yml.github/workflows/build-emsdk.yml.github/workflows/build-macos.yml.github/workflows/build-manylinux.yml.github/workflows/build-sdl3.yml.github/workflows/build-ubuntu-sdist.yml.github/workflows/build-windows.yml.github/workflows/dev-check.yml.github/workflows/release-gh-draft.yml.github/workflows/release-pypi.yml.github/workflows/run-ubuntu-checks.yml
ankith26
force-pushed
the
ankith26-zizmor
branch
from
March 29, 2026 04:58
57012c3 to
4329d03
Compare
Starbuck5
approved these changes
Apr 5, 2026
Starbuck5
left a comment
Starbuck5
left a comment
Member
There was a problem hiding this comment.
Did you mean to add permissions to build-manylinux as well?
Otherwise happy to go with this, thanks for checking it out Ankith.
Member
Author
|
build-manylinux already has permissions defined but at the job level not workflow level. This is fine for now because the workflow has only one job defined but this can be changes in the future. |
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After learning about the recent litellm security incident (TL;DR: supply chain attack via github actions, the PyPI token of a popular library was leaked to attackers who released bad releases that then compromised user creds and so on) I was prompted into further scrutinizing our own actions for security.
The good news is that we are already pretty secure in terms of PyPI publishing. We don't use a static PyPI token and instead use the recommended Trusted PyPI Publisher approach for managing our releases. So an attack like the above mentioned case wouldn't be possible with us.
But still, to be cautious (using zizmor for github actions static analysis) this PR identifies and fixes a couple of security gotchas, mainly under three categories: