Skip to content

pytest_runtest_logstart and pytest_runtest_logfinish are not in effect #31

Closed

Description

@wy-z

pytest-forked reimplemented pytest_runtest_protocol, but pytest_runtest_logstart and pytest_runtest_logfinish were ignored.

Here are the codes in pytest-forked and pytest:

def pytest_runtest_protocol(item):
if item.config.getvalue("forked") or item.get_closest_marker("forked"):
reports = forked_run_report(item)
for rep in reports:
item.ihook.pytest_runtest_logreport(report=rep)
return True

https://github.com/pytest-dev/pytest/blob/259e5d0610202453f9beace6cab336b11d4353a9/src/_pytest/runner.py#L87
image

Activity

  1. wy-z commented on Apr 29, 2020

    @wy-z
    Author

    How about implementing pytest_runtest_logstart and pytest_runtest_logfinish in pytest_runtestloop instead of in pytest_runtest_protocol? @nicoddemus
    https://github.com/pytest-dev/pytest/blob/4f8fff9cab6e2333890e21eb840724e7e4d41763/src/_pytest/main.py#L260-L277
    image

  2. webknjaz commented on Jul 2, 2020

    @webknjaz
    Member

    @wy-z this library is in maintenance mode. It is unlikely that the maintainers will implement your request but if you want to send a PR — feel free. Just make sure that it's well-covered by tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions