[Tune] Add Tuner.can_restore(path) utility for checking if an experiment exists at a path/uri - #32003
Merged
Merged
Conversation
Signed-off-by: Justin Yu <justinvyu@berkeley.edu> Add missing sentence Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
…/can_restore_utility
Yard1
approved these changes
Jan 31, 2023
Co-authored-by: Antoni Baum <antoni.baum@protonmail.com> Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
…yu/ray into tune/can_restore_utility
…/can_restore_utility
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
krfricke
approved these changes
Feb 1, 2023
Comment on lines
+973
to
+975
| path = tmp_path / name | ||
| if upload_dir: | ||
| path = Path(upload_dir) / name |
Contributor
There was a problem hiding this comment.
Nit for readability
Suggested change
| path = tmp_path / name | |
| if upload_dir: | |
| path = Path(upload_dir) / name | |
| if upload_dir: | |
| path = Path(upload_dir) / name | |
| else: | |
| path = tmp_path / name |
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
…/can_restore_utility Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…iment exists at a path/uri (ray-project#32003) This PR adds a utility to check if a given path (either local or remote) exists and can be restored from. It includes some simple validation that this is the root of the experiment directory (can't restore from the trial level directory). Signed-off-by: Justin Yu <justinvyu@berkeley.edu> Signed-off-by: Justin Yu <justinvyu@anyscale.com> Co-authored-by: Antoni Baum <antoni.baum@protonmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds a utility to check if a given path (either local or remote) exists and can be restored from. It includes some simple validation that this is the root of the experiment directory (can't restore from the trial level directory).
Example workflow that this should be used in:
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.