[tune/execution][rfc] Cache ready futures in RayTrialExecutor - #32093
Merged
Conversation
added 2 commits
January 30, 2023 17:53
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
added 4 commits
January 31, 2023 08:29
xwjiang2010
reviewed
Feb 1, 2023
Signed-off-by: Kai Fricke <kai@anyscale.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…oject#32093) We currently resolve futures one-by-one in Ray Tune, and query Ray core for the ready status of future multiple times. Instead, we can also cache ready events and yield them if cached elements exist. This can improve performance: In tune_scalability_result_cluster_throughput this improved performance by ~2-3%. We will always re-query Ray if we expect a resource to be ready. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke kai@anyscale.com
Why are these changes needed?
We currently resolve futures one-by-one in Ray Tune, and query Ray core for the ready status of future multiple times. Instead, we can also cache ready events and yield them if cached elements exist. This can improve performance: In tune_scalability_result_cluster_throughput this improved performance by ~2-3%.
We will always re-query Ray if we expect a resource to be ready.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.