[core] Fix gRPC callback API destruction issues. - #32151
Merged
Merged
Conversation
fishbone
marked this pull request as ready for review
February 8, 2023 01:39
Signed-off-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
scv119
approved these changes
Feb 9, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
For gRPC callback API, in the server and client side, the lifecycle is different. For server, it has to call Finish to make the call be considered as dead by gRPC and this can only be called once. For client, it will destruct itself if it receive the signal from the server or the connection is broken due to some reasons. There are two issues here in ray syncer: server might call Finish twice because server has OnWriteDone/OnReadDone. The fix is that when error happened, we'll call Finish and we'll guarantee that it's only called once. client might destruct itself, because client didn't have anything added to control that. The fix is to add AddHole/RemoveHole in the code to explicit control that just like server side. Testing is tricky, but it can be caught by nightly tests. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yi Cheng 74173148+iycheng@users.noreply.github.com
Why are these changes needed?
For gRPC callback API, in the server and client side, the lifecycle is different.
For server, it has to call
Finishto make the call be considered as dead by gRPC and this can only be called once.For client, it will destruct itself if it receive the signal from the server or the connection is broken due to some reasons.
There are two issues here in ray syncer:
Testing is tricky, but it can be caught by nightly tests.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.