Skip to content

[Tune] Remove Ray Client references from Tune and Train docs/examples - #32299

Merged
krfricke merged 16 commits into
ray-project:masterfrom
justinvyu:remove_ray_client_libraries
Feb 8, 2023
Merged

[Tune] Remove Ray Client references from Tune and Train docs/examples#32299
krfricke merged 16 commits into
ray-project:masterfrom
justinvyu:remove_ray_client_libraries

Conversation

@justinvyu

@justinvyu justinvyu commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

Why are these changes needed?

This PR removes references to Ray Client in Tune and Train examples. It also removes outdated references of needing ray.init("auto") being used to connect to an existing cluster vs. ray.init() creating a new local cluster.

The latest ray.init() docstring explains that:

This method handles two cases; either a Ray cluster already exists and we just attach this driver to it or we start all of the processes associated with a Ray cluster and attach to the newly started cluster.

New version of this PR: #31712

Related issue number

Closes #31621
Closes #30227 (fixes the pbt_ppo_example.ipynb config to use a valid Humanoid env, and cleans up the display output)

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@justinvyu
Remove ray client references from Tune examples
6829c38 
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
@justinvyu
Remove ray client from tune user guides
a09bc3c 
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
@justinvyu
Remove ray client from ray air examples
c6693ca 
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into remo…
3ee9ef7 
…ve_ray_client_libraries
@justinvyu
Fix pbt ppo example
40191e3 
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
@justinvyu
Format notebook with black
1414b4f 
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
@justinvyu
Format notebooks with black
5b8a5ed 
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into remo…
739856e 
…ve_ray_client_libraries
@justinvyu
Remove ray client references from tune/*.py and train/*.py examples
c0441fd 
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
@justinvyu
Fix lint
5787628 
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
@justinvyu
Revert "Remove ray client from tune user guides"
35e23e4 
This reverts commit a09bc3c.
@justinvyu
Remove reference in tune tutorials
1da413d 
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into remo…
187447f 
…ve_ray_client_libraries
@justinvyu
Update horovod smoke test to allocate enough resources
3d70f66 
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
@justinvyu
Address review comments
5b86459 
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
@justinvyu
Merge branch 'master' of https://github.com/ray-project/ray into remo…
5b267e3 
…ve_ray_client_libraries

Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
richardliaw
richardliaw approved these changes Feb 8, 2023
View reviewed changes
Comment thread doc/source/tune/examples/pbt_transformers.ipynb
@richardliaw

richardliaw commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

Are tests failures related?

@justinvyu

justinvyu commented Feb 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@richardliaw Unrelated, those are rllib tests that aren't touched by this PR.

krfricke
krfricke approved these changes Feb 8, 2023
View reviewed changes

@krfricke krfricke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krfricke
krfricke merged commit e84fcb1 into ray-project:master Feb 8, 2023
justinvyu added a commit to justinvyu/ray that referenced this pull request Feb 8, 2023
@justinvyu
[Tune] Remove Ray Client references from Tune and Train docs/examples (…
5543f16 
…ray-project#32299)

This PR removes references to Ray Client in Tune and Train examples. It also removes outdated references of needing `ray.init("auto")` being used to connect to an existing cluster vs. `ray.init()` creating a new local cluster.

The latest `ray.init()` docstring explains that:

> This method handles two cases; either a Ray cluster already exists and we just attach this driver to it or we start all of the processes associated with a Ray cluster and attach to the newly started cluster.

New version of this PR: ray-project#31712

Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
@justinvyu justinvyu mentioned this pull request Feb 8, 2023
Merged
7 tasks
matthewdeng pushed a commit that referenced this pull request Feb 10, 2023
@justinvyu
[Tune] Remove Ray Client references from Tune and Train docs/examples (…
f5ac58a 
…#32299) (#32321)

This PR removes references to Ray Client in Tune and Train examples. It also removes outdated references of needing `ray.init("auto")` being used to connect to an existing cluster vs. `ray.init()` creating a new local cluster.

The latest `ray.init()` docstring explains that:

> This method handles two cases; either a Ray cluster already exists and we just attach this driver to it or we start all of the processes associated with a Ray cluster and attach to the newly started cluster.

New version of this PR: #31712

Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@justinvyu @edoakes
[Tune] Remove Ray Client references from Tune and Train docs/examples (…
12ed6a2 
…ray-project#32299)

This PR removes references to Ray Client in Tune and Train examples. It also removes outdated references of needing `ray.init("auto")` being used to connect to an existing cluster vs. `ray.init()` creating a new local cluster.

The latest `ray.init()` docstring explains that:

> This method handles two cases; either a Ray cluster already exists and we just attach this driver to it or we start all of the processes associated with a Ray cluster and attach to the newly started cluster.

New version of this PR: ray-project#31712

Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardliaw richardliaw richardliaw approved these changes
@krfricke krfricke krfricke approved these changes
@gjoliver gjoliver Awaiting requested review from gjoliver
@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010
@amogkam amogkam Awaiting requested review from amogkam
@matthewdeng matthewdeng Awaiting requested review from matthewdeng
@Yard1 Yard1 Awaiting requested review from Yard1
@maxpumperla maxpumperla Awaiting requested review from maxpumperla

Assignees

@matthewdeng matthewdeng

@richardliaw richardliaw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[client][ml] Remove Ray Client references from Libraries Documentation and Examples Issue on page /tune/examples/pbt_ppo_example.html

4 participants

@justinvyu @richardliaw @krfricke @matthewdeng