[AIR] Fix CountVectorizer failing with big data - #32351
Merged
Merged
Conversation
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Yard1
requested review from
amogkam,
bveeramani,
clarkzinzow,
jiaodong and
matthewdeng
as code owners
February 9, 2023 01:10
bveeramani
approved these changes
Feb 9, 2023
Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Fixes bad return type in an internal CountVectorizer logic that caused it to fail if a Dataset task processed multiple batches instead of just one. Test has been updated. --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
Fixes bad return type in an internal CountVectorizer logic that caused it to fail if a Dataset task processed multiple batches instead of just one. Test has been updated. --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Fixes bad return type in an internal CountVectorizer logic that caused it to fail if a Dataset task processed multiple batches instead of just one. Test has been updated. --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: elliottower <elliot@elliottower.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antoni Baum antoni.baum@protonmail.com
Why are these changes needed?
Fixes bad return type in an internal
CountVectorizerlogic that caused it to fail if a Dataset task processed multiple batches instead of just one. Test has been updated.Related issue number
Closes https://discuss.ray.io/t/xgboost-ray-crashes-when-used-for-multiclass-text-classification/9248/3
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.