[AIR] Allow users to pass Callable[[torch.Tensor], torch.Tensor] to TorchVisionTransform - #32383
Merged
amogkam merged 5 commits intoFeb 10, 2023
Merged
Conversation
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
requested review from
Yard1,
amogkam,
clarkzinzow,
jiaodong and
matthewdeng
as code owners
February 9, 2023 22:48
12 tasks
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Callable[[np.ndarray], torch.Tensor] to TorchVisionTransformCallable[[torch.Tensor], torch.Tensor] to TorchVisionTransform
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Member
Author
|
Test failures are unrelated. |
Contributor
|
Can you please add a pr description? |
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
β¦ `TorchVisionTransform` (ray-project#32383) Transforms like RandomHorizontalFlip expect Torch tensors as input, but if you're applying the transform per-epoch, then you can't use ToTensor. To fix the problem, this PR updates TorchVisionPreprocessor to convert ndarray inputs to Torch tensors. You can't use ToTensor to convert the ndarrays to Torch tensors because then you'd be applying ToTensor twice, and your images would get scaled incorrectly. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Balaji Veeramani balaji@anyscale.com
Why are these changes needed?
Transforms like
RandomHorizontalFlipexpect Torch tensors as input, but if you're applying the transform per-epoch, then you can't useToTensor. To fix the problem, this PR updatesTorchVisionPreprocessorto convert ndarray inputs to Torch tensors.You can't use
ToTensorto convert the ndarrays to Torch tensors because then you'd be applyingToTensortwice, and your images would get scaled incorrectly.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.