[ci][core] Do not set flushing thread niceness for task backend - #32439
Merged
Conversation
rkooo567
approved these changes
Feb 10, 2023
Member
Author
|
Local tests on
Running microbenchmark here: https://buildkite.com/ray-project/release-tests-pr/builds/28110#01863d1f-ab9b-4f25-99f6-53a849a516c2 |
Member
Author
|
Should we merge this and CP @rkooo567 @cadedaniel ? |
Member
Author
|
Opening CP - if that's still ok. |
Member
|
Yep we need this -- this is a test failure on the release branch |
scv119
pushed a commit
that referenced
this pull request
Feb 10, 2023
Signed-off-by: rickyyx <rickyx@anyscale.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…roject#32439 We believe this has minimal impact on the performance. So reverting for non-necessary code. Signed-off-by: rickyyx <rickyx@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rickyyx rickyx@anyscale.com
Why are these changes needed?
This breaks macos test with
We believe this has minimal impact on the performance. So reverting for non-necessary code.
Related issue number
Closes #32405
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.