[Docs] Fix broken Tune links to overview and intergration - #32442
Merged
richardliaw merged 1 commit intoFeb 10, 2023
Conversation
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
ArturNiederfahrenhorst
added
the
docs
justinvyu
reviewed
Feb 10, 2023
Comment on lines
150
to
+151
| "The above snippet was taken from the\n", | ||
| "[Tune API documentation](https://github.com/ray-project/ray/blob/master/doc/source/tune/api_docs/integration.rst),\n", | ||
| "[Tune API documentation](https://github.com/ray-project/ray/blob/master/doc/source/tune/api/integration.rst),\n", |
Contributor
There was a problem hiding this comment.
This is no longer the case -- we can remove this line. I'll create an issue about adding the new way of adding API references using autosummary.
Contributor
Author
There was a problem hiding this comment.
What is no longer the case? Feel free to edit this PR if you think there is a superior fix! 🙂
Contributor
There was a problem hiding this comment.
The snippet it's mentioning is outdated now and doesn't match the github link anymore. We can just remove this sentence for now.
Nvm. We can update this section fully in a follow-up PR. Let's just fix the broken links for now.
justinvyu
approved these changes
Feb 10, 2023
richardliaw
approved these changes
Feb 10, 2023
Contributor
Author
|
Thanks |
justinvyu
pushed a commit
to justinvyu/ray
that referenced
this pull request
Feb 10, 2023
7 tasks
cadedaniel
pushed a commit
that referenced
this pull request
Feb 13, 2023
* [Tune][Doc] Restructure API reference (#32311) * [Docs] Fix broken Tune links to overview and intergration (#32442) * Remove can_restore (exists on master but not releases/2.3.0) Signed-off-by: Justin Yu <justinvyu@berkeley.edu> --------- Signed-off-by: Justin Yu <justinvyu@berkeley.edu> Co-authored-by: Artur Niederfahrenhorst <artur@anyscale.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…t#32442) Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst artur@anyscale.com
Why are these changes needed?
@justinvyu Heads-up: I believe this was introduced here: 613f4b0