[ci] Allow using local wheels to run release tests. - #32739
Merged
Merged
Conversation
rickyyx
marked this pull request as ready for review
February 25, 2023 00:57
rickyyx
requested review from
Yard1,
krfricke,
rkooo567 and
simon-mo
as code owners
February 25, 2023 00:57
Contributor
|
Will leave it up to @krfricke |
krfricke
reviewed
Feb 27, 2023
krfricke
left a comment
krfricke
left a comment
Contributor
There was a problem hiding this comment.
Looks good, minor nits.
Have you tested this locally (does it work)?
…i-release-wheel
Member
Author
Yep, I have been using it:
You could also see the bucket here: https://s3.console.aws.amazon.com/s3/buckets/ray-release-manual-wheels?region=us-west-2&tab=objects |
krfricke
approved these changes
Mar 30, 2023
krfricke
left a comment
krfricke
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, thanks! cc @can-anyscale for reference: This is for local CLI mode (not buildkite) so I think we can go ahead for now. It also only affects the buildfarm, not the actual cluster where it's running on, so it should be compatible with gce.
Contributor
|
verynice |
can-anyscale
pushed a commit
that referenced
this pull request
Mar 30, 2023
This allows one to directly run release tests on a local wheel built so one doesn't need to wait for PR wheel build. Signed-off-by: rickyyx <rickyx@anyscale.com>
can-anyscale
pushed a commit
that referenced
this pull request
Mar 30, 2023
This allows one to directly run release tests on a local wheel built so one doesn't need to wait for PR wheel build. Signed-off-by: rickyyx <rickyx@anyscale.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
This allows one to directly run release tests on a local wheel built so one doesn't need to wait for PR wheel build. Signed-off-by: rickyyx <rickyx@anyscale.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
This allows one to directly run release tests on a local wheel built so one doesn't need to wait for PR wheel build. Signed-off-by: rickyyx <rickyx@anyscale.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This allows one to directly run release tests on a local wheel built so one doesn't need to wait for PR wheel build.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.