[AIR/Docs] Large model inference examples - #32874
Merged
Merged
Conversation
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
richardliaw
reviewed
Feb 28, 2023
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Yard1
marked this pull request as ready for review
February 28, 2023 23:48
Yard1
requested review from
a team,
amogkam,
gjoliver,
krfricke,
matthewdeng,
maxpumperla and
xwjiang2010
as code owners
February 28, 2023 23:48
ericl
reviewed
Mar 1, 2023
ericl
left a comment
Contributor
There was a problem hiding this comment.
Looks good at a high level. Should we add a TODO to add a larger-scale example? This one is quite small.
Member
Author
|
@ericl I think it's fine to keep them small - after all, it is that easy. The DeepSpeed example I am working on will be bigger and more advanced, and the same goes for fine-tuning examples that are next in line. |
ericl
reviewed
Mar 1, 2023
ericl
reviewed
Mar 1, 2023
richardliaw
reviewed
Mar 1, 2023
richardliaw
reviewed
Mar 1, 2023
richardliaw
reviewed
Mar 1, 2023
richardliaw
reviewed
Mar 1, 2023
richardliaw
left a comment
Contributor
There was a problem hiding this comment.
all same comments apply across notebooks. nice work!
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
richardliaw
reviewed
Mar 1, 2023
richardliaw
approved these changes
Mar 1, 2023
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
ericl
approved these changes
Mar 1, 2023
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
* WIP Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Update versions Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * WIP Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Update toc Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Cleanup Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Apply feedback Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Apply feedback Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Fix Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
* WIP Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Update versions Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * WIP Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Update toc Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Cleanup Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Apply feedback Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Apply feedback Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Fix Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
* WIP Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Update versions Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * WIP Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Update toc Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Cleanup Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Apply feedback Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Apply feedback Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Fix Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
* WIP Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Update versions Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * WIP Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Update toc Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Cleanup Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Apply feedback Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Apply feedback Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Fix Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
* WIP Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Update versions Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * WIP Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Update toc Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Cleanup Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Apply feedback Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Apply feedback Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> * Fix Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds two simple examples showing how to do batch inference with Ray Data using Stable Diffusion and GPT-J models.
Note that the datasets used are very small, allowing them to be ran quickly by both the user and CI. Examples with large scale datasets (>=1 TB) are left as a TODO.
DeepSpeed Inference example will be added in a separate PR.
We are using Ray Data instead of
BatchPredictordue to #32923.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.