[Train] Support returning multiple devices in train.torch.get_device() - #32893
Merged
Conversation
krfricke
approved these changes
Feb 28, 2023
krfricke
left a comment
Contributor
There was a problem hiding this comment.
Thanks, LGTM.
This will still require us to change the prepare_model() methods to allow to select a specific device. We can update this in a follow-up (we may just want to pass in the cuda device ID directly and otherwise default to get_device()[0]
Contributor
Author
|
Good point, updated |
Member
|
Isn't this technically a breaking change that would require a deprecation cycle? |
Contributor
Author
|
I think it should be fine since this is only affecting the multi-GPU case and this is still beta API, but I will update to log a warning about the change. |
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
ā¦()` (ray-project#32893) For model parallel workloads like stable diffusion fine-tuning, we may want to use multiple GPUs per Ray Train worker. This PR implements support for train.torch.get_device() returning a List of devices for these use cases so that users do not need to manage device setting themselves. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
ā¦()` (ray-project#32893) For model parallel workloads like stable diffusion fine-tuning, we may want to use multiple GPUs per Ray Train worker. This PR implements support for train.torch.get_device() returning a List of devices for these use cases so that users do not need to manage device setting themselves. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
ā¦()` (ray-project#32893) For model parallel workloads like stable diffusion fine-tuning, we may want to use multiple GPUs per Ray Train worker. This PR implements support for train.torch.get_device() returning a List of devices for these use cases so that users do not need to manage device setting themselves. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com>
8 tasks
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
ā¦()` (ray-project#32893) For model parallel workloads like stable diffusion fine-tuning, we may want to use multiple GPUs per Ray Train worker. This PR implements support for train.torch.get_device() returning a List of devices for these use cases so that users do not need to manage device setting themselves. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
ā¦()` (ray-project#32893) For model parallel workloads like stable diffusion fine-tuning, we may want to use multiple GPUs per Ray Train worker. This PR implements support for train.torch.get_device() returning a List of devices for these use cases so that users do not need to manage device setting themselves. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For model parallel workloads like stable diffusion fine-tuning, we may want to use multiple GPUs per Ray Train worker. This PR implements support for
train.torch.get_device()returning a List of devices for these use cases so that users do not need to manage device setting themselves.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.