[Datasets] Add missing passthrough args to read_images() - #32942
Merged
Conversation
clarkzinzow
requested review from
c21,
ericl,
jianoaix,
jjyao and
scv119
as code owners
March 1, 2023 17:08
jianoaix
approved these changes
Mar 1, 2023
c21
approved these changes
Mar 1, 2023
c21
left a comment
c21
left a comment
Contributor
There was a problem hiding this comment.
LG assuming unit test to be added.
clarkzinzow
force-pushed
the
datasets/feat/read-images-passthroughs
branch
from
March 29, 2023 17:22
d4ae194 to
701125f
Compare
c21
reviewed
Mar 29, 2023
Comment on lines
+633
to
+635
| ray_remote_args: kwargs passed to ray.remote in the read tasks. | ||
| arrow_open_file_args: kwargs passed to | ||
| ``pyarrow.fs.FileSystem.open_input_file``. |
Contributor
There was a problem hiding this comment.
nit: can we follow the same ordering, to add these two parameters after meta_provider?
Contributor
Author
There was a problem hiding this comment.
Ah yep, looks like these got reordered when resolving merge conflicts, I'll fix that!
c21
approved these changes
Mar 29, 2023
Contributor
|
@zhe-thoughts - can you approve this? |
zhe-thoughts
approved these changes
Mar 29, 2023
zhe-thoughts
left a comment
zhe-thoughts
left a comment
Contributor
There was a problem hiding this comment.
Approved for merging to master
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…#32942) This PR adds missing passthrough args to read_images(), such as ray_remote_args, arrow_open_file_args, and other misc. args popped in the base FileBasedDatasource such as compression. This PR also adds a **read_args catch-all to ImageDatasource._read_file(), which should add support for using the local:// protocol. Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…#32942) This PR adds missing passthrough args to read_images(), such as ray_remote_args, arrow_open_file_args, and other misc. args popped in the base FileBasedDatasource such as compression. This PR also adds a **read_args catch-all to ImageDatasource._read_file(), which should add support for using the local:// protocol. Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing passthrough args to
read_images(), such asray_remote_args,arrow_open_file_args, and other misc. args popped in the baseFileBasedDatasourcesuch ascompression. This PR also adds a**read_argscatch-all toImageDatasource._read_file(), which should add support for using thelocal://protocol.Related issue number
Closes #32941
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.