Skip to content

[Train] Deflake test_gpu by sorting the devices - #33002

Merged
amogkam merged 3 commits into
ray-project:masterfrom
amogkam:fix-torch-2
Mar 3, 2023
Merged

[Train] Deflake test_gpu by sorting the devices#33002
amogkam merged 3 commits into
ray-project:masterfrom
amogkam:fix-torch-2

Conversation

@amogkam

@amogkam amogkam commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

Deflake test_gpu by sorting the devices during assertion.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

amogkam added 3 commits March 3, 2023 10:00
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@amogkam
amogkam merged commit 61582be into ray-project:master Mar 3, 2023
@amogkam
amogkam deleted the fix-torch-2 branch March 3, 2023 21:31
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
Deflake test_gpu by sorting the devices during assertion.

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
Deflake test_gpu by sorting the devices during assertion.

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
Deflake test_gpu by sorting the devices during assertion.

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
Deflake test_gpu by sorting the devices during assertion.

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
Deflake test_gpu by sorting the devices during assertion.

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants