[train] Update quickstart example to use dataloader - #33050
Merged
Merged
Conversation
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Matthew Deng <matt@anyscale.com>
matthewdeng
requested review from
a team,
Yard1,
amogkam,
krfricke,
maxpumperla,
richardliaw and
xwjiang2010
as code owners
March 6, 2023 02:16
matthewdeng
added
the
tests-ok
amogkam
reviewed
Mar 6, 2023
Contributor
There was a problem hiding this comment.
should we consolidate with the existing fashion mnist example? https://docs.ray.io/en/latest/train/examples/pytorch/torch_fashion_mnist_example.html
Contributor
Author
|
@amogkam I chose not to because I wanted to keep this one as minimal as possible (e.g. no validation, no configurations). |
amogkam
approved these changes
Mar 6, 2023
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
To simplify the CPU/GPU transition, Ray Train provides a ray.train.torch.prepare_data_loader utility function. Prior to this change, this logic was not being handled so the example would fail if run with use_gpu=True. --------- Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
To simplify the CPU/GPU transition, Ray Train provides a ray.train.torch.prepare_data_loader utility function. Prior to this change, this logic was not being handled so the example would fail if run with use_gpu=True. --------- Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
To simplify the CPU/GPU transition, Ray Train provides a ray.train.torch.prepare_data_loader utility function. Prior to this change, this logic was not being handled so the example would fail if run with use_gpu=True. --------- Signed-off-by: Matthew Deng <matt@anyscale.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
To simplify the CPU/GPU transition, Ray Train provides a ray.train.torch.prepare_data_loader utility function. Prior to this change, this logic was not being handled so the example would fail if run with use_gpu=True. --------- Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
To simplify the CPU/GPU transition, Ray Train provides a ray.train.torch.prepare_data_loader utility function. Prior to this change, this logic was not being handled so the example would fail if run with use_gpu=True. --------- Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
TorchTrainerquickstart example to be a little more realistic, following the official PyTorch Quickstart.Why are these changes needed?
To simplify the CPU/GPU transition, Ray Train provides a
ray.train.torch.prepare_data_loaderutility function. Prior to this change, this logic was not being handled so the example would fail if run withuse_gpu=True.Changes
Dataloaderfor theFashionMNISTdataset. Updated surrounding code accordingly.Related issue number
Closes #32990.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.