[AIR] Fix test_tracked_actor unit test - #33075
Merged
krfricke merged 2 commits intoMar 7, 2023
Merged
Conversation
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
…fix_test_tracked_actor
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
`test_tracked_actor` hangs due to a combination of shared pytest fixture + fixed resource allocation + placement groups not being cleaned up immediately after the test. This test calls `gc.collect` to force the cleanup to happen at the beginning of the test. Signed-off-by: Justin Yu <justinvyu@berkeley.edu> Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
`test_tracked_actor` hangs due to a combination of shared pytest fixture + fixed resource allocation + placement groups not being cleaned up immediately after the test. This test calls `gc.collect` to force the cleanup to happen at the beginning of the test. Signed-off-by: Justin Yu <justinvyu@berkeley.edu> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
`test_tracked_actor` hangs due to a combination of shared pytest fixture + fixed resource allocation + placement groups not being cleaned up immediately after the test. This test calls `gc.collect` to force the cleanup to happen at the beginning of the test. Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
`test_tracked_actor` hangs due to a combination of shared pytest fixture + fixed resource allocation + placement groups not being cleaned up immediately after the test. This test calls `gc.collect` to force the cleanup to happen at the beginning of the test. Signed-off-by: Justin Yu <justinvyu@berkeley.edu> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
`test_tracked_actor` hangs due to a combination of shared pytest fixture + fixed resource allocation + placement groups not being cleaned up immediately after the test. This test calls `gc.collect` to force the cleanup to happen at the beginning of the test. Signed-off-by: Justin Yu <justinvyu@berkeley.edu> Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
test_tracked_actorhangs due to a combination of shared pytest fixture + fixed resource allocation + placement groups not being cleaned up immediately after the test. This test callsgc.collectto force the cleanup to happen at the beginning of the test.Related issue number
#31738
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.