[AIR] Allow None in set_preprocessor - #33088
Merged
Merged
Conversation
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
7 tasks
amogkam
approved these changes
Mar 7, 2023
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
* [AIR] Allow None in `Checkpoint.set_preprocessor` This PR allows users to remove a preprocessor from Checkpoint/BatchPredictor by letting set_preprocessor take in a None value (previously, this resulted in a noop). --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
* [AIR] Allow None in `Checkpoint.set_preprocessor` This PR allows users to remove a preprocessor from Checkpoint/BatchPredictor by letting set_preprocessor take in a None value (previously, this resulted in a noop). --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
* [AIR] Allow None in `Checkpoint.set_preprocessor` This PR allows users to remove a preprocessor from Checkpoint/BatchPredictor by letting set_preprocessor take in a None value (previously, this resulted in a noop). --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
* [AIR] Allow None in `Checkpoint.set_preprocessor` This PR allows users to remove a preprocessor from Checkpoint/BatchPredictor by letting set_preprocessor take in a None value (previously, this resulted in a noop). --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
* [AIR] Allow None in `Checkpoint.set_preprocessor` This PR allows users to remove a preprocessor from Checkpoint/BatchPredictor by letting set_preprocessor take in a None value (previously, this resulted in a noop). --------- Signed-off-by: Antoni Baum <antoni.baum@protonmail.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR allows users to remove a preprocessor from
Checkpoint/BatchPredictorby lettingset_preprocessortake in aNonevalue (previously, this resulted in a noop).Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.