[serve] Add support for multi app to serve build - #33216
Merged
Merged
Conversation
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
shrekris-anyscale
left a comment
shrekris-anyscale
left a comment
Contributor
There was a problem hiding this comment.
Nice work so far! I left some comments.
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
shrekris-anyscale
approved these changes
Mar 13, 2023
shrekris-anyscale
left a comment
shrekris-anyscale
left a comment
Contributor
There was a problem hiding this comment.
Great work on this change!
sihanwang41
approved these changes
Mar 13, 2023
Contributor
Author
|
@edoakes ready for merge! |
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
Users should be able to build multiple app targets into one `ServeDeploySchema` file using one `serve build` command, which can then be submitted through `serve deploy` or `PUT /api/serve/applications`. - By default, `serve build` will only accept one import path. - If the feature flag `--multi-app` or `-m` is specified, `serve build` will accept 1 or more import paths. The app configs are identical to the single-app config *except*: - `route_prefix` is extracted from the ingress deployment and placed at the application level of the configs - Auto-generated names `app1`, `app2`, ... etc are added to the application level of the configs - Host and port are removed from the application level of the configs and placed at the top level of the deploy config Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Users should be able to build multiple app targets into one `ServeDeploySchema` file using one `serve build` command, which can then be submitted through `serve deploy` or `PUT /api/serve/applications`. - By default, `serve build` will only accept one import path. - If the feature flag `--multi-app` or `-m` is specified, `serve build` will accept 1 or more import paths. The app configs are identical to the single-app config *except*: - `route_prefix` is extracted from the ingress deployment and placed at the application level of the configs - Auto-generated names `app1`, `app2`, ... etc are added to the application level of the configs - Host and port are removed from the application level of the configs and placed at the top level of the deploy config Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
Users should be able to build multiple app targets into one `ServeDeploySchema` file using one `serve build` command, which can then be submitted through `serve deploy` or `PUT /api/serve/applications`. - By default, `serve build` will only accept one import path. - If the feature flag `--multi-app` or `-m` is specified, `serve build` will accept 1 or more import paths. The app configs are identical to the single-app config *except*: - `route_prefix` is extracted from the ingress deployment and placed at the application level of the configs - Auto-generated names `app1`, `app2`, ... etc are added to the application level of the configs - Host and port are removed from the application level of the configs and placed at the top level of the deploy config
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Users should be able to build multiple app targets into one `ServeDeploySchema` file using one `serve build` command, which can then be submitted through `serve deploy` or `PUT /api/serve/applications`. - By default, `serve build` will only accept one import path. - If the feature flag `--multi-app` or `-m` is specified, `serve build` will accept 1 or more import paths. The app configs are identical to the single-app config *except*: - `route_prefix` is extracted from the ingress deployment and placed at the application level of the configs - Auto-generated names `app1`, `app2`, ... etc are added to the application level of the configs - Host and port are removed from the application level of the configs and placed at the top level of the deploy config Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
Users should be able to build multiple app targets into one `ServeDeploySchema` file using one `serve build` command, which can then be submitted through `serve deploy` or `PUT /api/serve/applications`. - By default, `serve build` will only accept one import path. - If the feature flag `--multi-app` or `-m` is specified, `serve build` will accept 1 or more import paths. The app configs are identical to the single-app config *except*: - `route_prefix` is extracted from the ingress deployment and placed at the application level of the configs - Auto-generated names `app1`, `app2`, ... etc are added to the application level of the configs - Host and port are removed from the application level of the configs and placed at the top level of the deploy config Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Users should be able to build multiple app targets into one
ServeDeploySchemafile using oneserve buildcommand, which can then be submitted throughserve deployorPUT /api/serve/applications.serve buildwill only accept one import path.--multi-appor-mis specified,serve buildwill accept 1 or more import paths. The app configs are identical to the single-app config except:route_prefixis extracted from the ingress deployment and placed at the application level of the configsapp1,app2, ... etc are added to the application level of the configsRelated issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.