Skip to content

[Core] Remove some usage of deprecated runtime context apis - #33236

Merged
jjyao merged 3 commits into
ray-project:masterfrom
jjyao:jjyao/deprecate
Mar 14, 2023
Merged

[Core] Remove some usage of deprecated runtime context apis#33236
jjyao merged 3 commits into
ray-project:masterfrom
jjyao:jjyao/deprecate

Conversation

@jjyao

@jjyao jjyao commented Mar 12, 2023

Copy link
Copy Markdown
Contributor

Why are these changes needed?

  • Removed some usage of deprecated runtime context apis
  • Removed some dead code

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao
jjyao requested a review from a team as a code owner March 12, 2023 19:25

@jovany-wang jovany-wang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 13, 2023
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Comment thread python/ray/runtime_context.py Outdated
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao
jjyao merged commit 1baaa57 into ray-project:master Mar 14, 2023
@jjyao
jjyao deleted the jjyao/deprecate branch March 14, 2023 21:26
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
…ect#33236)

- Removed some usage of deprecated runtime context apis
- Removed some dead code

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…ect#33236)

- Removed some usage of deprecated runtime context apis
- Removed some dead code

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
…ect#33236)

- Removed some usage of deprecated runtime context apis
- Removed some dead code

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 27, 2023
@jjyao jjyao mentioned this pull request Mar 27, 2023
8 tasks
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
…ect#33236)

- Removed some usage of deprecated runtime context apis
- Removed some dead code

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
…ect#33236)

- Removed some usage of deprecated runtime context apis
- Removed some dead code

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants