[RLlib] Remove all default config objects and rllib/agents - #33242
Merged
gjoliver merged 19 commits intoMar 17, 2023
Conversation
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
ArturNiederfahrenhorst
requested review from
avnishn,
gjoliver,
kouroshHakha,
krfricke,
maxpumperla and
smorad
as code owners
March 13, 2023 00:49
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
…missing configs Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
| >>> ppo = ppo_config.build(env="Pendulum-v1") | ||
| >>> from ray.rllib.algorithms.ppo.ppo import PPOConfig # doctest: +SKIP | ||
| >>> ppo_config = PPOConfig.from_dict({...}) # doctest: +SKIP | ||
| >>> ppo = ppo_config.build(env="Pendulum-v1") # doctest: +SKIP |
Contributor
Author
There was a problem hiding this comment.
I left this method here for now, since some folks might be actively using it still.
We can create deprecation warnings here if you will.
|
|
||
| policy = Policy.from_checkpoint(path_to_checkpoint) | ||
| self.assertTrue(isinstance(policy, Policy)) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
We can not support this anymore. Upholding this would require converting old config dicts inside of these checkpoints.
sven1977
reviewed
Mar 15, 2023
| ) | ||
| config["input_config"] = {"paths": config["output"]} | ||
| del config["output"] | ||
| del config.output |
Contributor
There was a problem hiding this comment.
Nit: I don't think we should del this here, since it's now a property. Just set it to None?
sven1977
approved these changes
Mar 15, 2023
sven1977
left a comment
sven1977
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Just one nit in my comments on del'ing a property.
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
ArturNiederfahrenhorst
changed the title
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
…ct#33242) Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…ct#33242) Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
…ct#33242) Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
chaowanggg
pushed a commit
to chaowanggg/ray-dev
that referenced
this pull request
Apr 4, 2023
…ct#33242) Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: chaowang <chaowang@anyscale.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…ct#33242) Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…ct#33242) Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
With Ray 2.0.0, we had made two migrations:
Trainer -> Algorithm
ConfigDicts -> AlgorithmConfig objects
This was over 8 months ago and appears to be a sufficient amount of time to fully deprecate the aliases for Trainers from the rllib/agent directory and the legacy config dicts _DEFAULT_CONFIG.
This is also necessary so that less config dicts trickle into RLlib to reduce errors that stem from us attemping to access these object's variables, while they still need to be indexed.
This PR is needed so that we can move forward with #29205